i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Tracker: Fix file handle leak while filtering poses

Browse Source 
... closing the file handle it opens and fixing #20018.

Change-Id: Ic6da22bf46fa24ec5f056f468d334c2d6e41069e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/11413
Reviewed-by: waddlesplash <[email protected]>
This commit is contained in:
John Scipione
2026-08-04 04:28:10 +00:00
committed by waddlesplash
parent be1b4b813d
commit 868b6993ea
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/tracker/PoseView.cpp
+4 -2
View File
@@ -10559,9 +10559,12 @@ BPoseView::FilterPose(BPose* pose)
if (pose == NULL || !IsFiltering()) if (pose == NULL || !IsFiltering())
return false; return false;
ModelNodeLazyOpener modelOpener(pose->TargetModel());
if (IsRefFiltering()) { if (IsRefFiltering()) {
modelOpener.OpenNode();
Model* model = pose->TargetModel(); Model* model = pose->TargetModel();
if (model->OpenNode() != B_OK) if (!model->IsNodeOpen())
return false; return false;
struct stat_beos stat; struct stat_beos stat;
@@ -10576,7 +10579,6 @@ BPoseView::FilterPose(BPose* pose)
bool found[stringCount]; bool found[stringCount];
memset(found, 0, sizeof(found)); memset(found, 0, sizeof(found));
ModelNodeLazyOpener modelOpener(pose->TargetModel());
for (int32 i = 0; i < CountColumns(); i++) { for (int32 i = 0; i < CountColumns(); i++) {
BTextWidget* widget = pose->WidgetFor(ColumnAt(i), this, modelOpener); BTextWidget* widget = pose->WidgetFor(ColumnAt(i), this, modelOpener);
const char* text = NULL; const char* text = NULL;