Fix todo and only unload listener from the last add-on.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42484 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/servers/app/Desktop.cpp

@@ -2047,18 +2047,18 @@ Desktop::RedrawBackground()
 
 
 bool
-Desktop::ReloadDecor()
+Desktop::ReloadDecor(DecorAddOn* oldDecor)
 {
 	AutoWriteLocker _(fWindowLock);
 
 	bool returnValue = true;
 
-	// TODO it is assumed all listeners are registered by one decor
+	if (oldDecor != NULL) {
-	// unregister old listeners
+		const DesktopListenerList* oldListeners
-	const DesktopListenerDLList& currentListeners = GetDesktopListenerList();
+			= &oldDecor->GetDesktopListeners();
-	for (DesktopListener* listener = currentListeners.First();
+		for (int i = 0; i < oldListeners->CountItems(); i++)
-		listener != NULL; listener = currentListeners.GetNext(listener))
+			UnregisterListener(oldListeners->ItemAt(i));
-		UnregisterListener(listener);
+	}
 
 	for (Window* window = fAllWindows.FirstWindow(); window != NULL;
 			window = window->NextWindow(kAllWindowList)) {

src/servers/app/Desktop.h

@@ -39,6 +39,7 @@
 
 class BMessage;
 
+class DecorAddOn;
 class DrawingEngine;
 class HWInterface;
 class ServerApp;
@@ -221,7 +222,7 @@ public:
 			void				Redraw();
 			void				RedrawBackground();
 
-			bool				ReloadDecor();
+			bool				ReloadDecor(DecorAddOn* oldDecor);
 
 			BRegion&			BackgroundRegion()
 									{ return fBackgroundRegion; }

src/servers/app/decorator/DecorManager.cpp

@@ -243,13 +243,14 @@ DecorManager::SetDecorator(BString path, Desktop* desktop)
 		return error == B_OK ? B_ERROR : error;
 
 	DecorAddOn* oldDecor = fCurrentDecor;
+
 	BString oldPath = fCurrentDecorPath;
 	image_id oldImage = fCurrentDecor->ImageID();
 
 	fCurrentDecor = newDecor;
 	fCurrentDecorPath = path.String();
 
-	if (desktop->ReloadDecor()) {
+	if (desktop->ReloadDecor(oldDecor)) {
 		// now safe to unload all old decorator data
 		// saves us from deleting oldDecor...
 		unload_add_on(oldImage);