From 899da7db5a4d86e3d544482678431d661f791194 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Sun, 10 Feb 2019 13:03:39 +0100 Subject: [PATCH] sdhci: Cleanup of registrer dump traces MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Try to group things on a single line where it makes sense - Use hexadecimal values where appropriate Change-Id: Ia5ebef84db5d511ea2603dfa4ffc9e90f7e86ca7 Reviewed-on: https://review.haiku-os.org/c/1027 Reviewed-by: Stephan Aßmus --- src/add-ons/kernel/busses/mmc/sdhci_pci.cpp | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/add-ons/kernel/busses/mmc/sdhci_pci.cpp b/src/add-ons/kernel/busses/mmc/sdhci_pci.cpp index a281e0ffc4..2cc0fe4346 100644 --- a/src/add-ons/kernel/busses/mmc/sdhci_pci.cpp +++ b/src/add-ons/kernel/busses/mmc/sdhci_pci.cpp @@ -59,17 +59,14 @@ static pci_x86_module_info* sPCIx86Module; static void sdhci_register_dump(uint8_t slot, struct registers* regs) { - TRACE("Register values for slot: %d\n", slot); + TRACE("Register values for slot %d:\n", slot); TRACE("system_address: %d\n", regs->system_address); - TRACE("block_size: %d\n", regs->block_size); - TRACE("block_count: %d\n", regs->block_count); + TRACE("%d blocks of size %d\n", regs->block_count, regs->block_size); TRACE("argument: %d\n", regs->argument); TRACE("transfer_mode: %d\n", regs->transfer_mode); TRACE("command: %d\n", regs->command); - TRACE("response0: %d\n", regs->response0); - TRACE("response2: %d\n", regs->response2); - TRACE("response4: %d\n", regs->response4); - TRACE("response6: %d\n", regs->response6); + TRACE("response: %d %d %d %d\n", regs->response0, regs->response2, + regs->response4, regs->response6); TRACE("buffer_data_port: %d\n", regs->buffer_data_port); TRACE("present_state: %d\n", regs->present_state); TRACE("power_control: %d\n", regs->power_control); @@ -79,9 +76,9 @@ sdhci_register_dump(uint8_t slot, struct registers* regs) TRACE("clock_control: %d\n", regs->clock_control); TRACE("software_reset: %d\n", regs->software_reset); TRACE("timeout_control: %d\n", regs->timeout_control); - TRACE("interrupt_status: %d\n", regs->interrupt_status); - TRACE("interrupt_status_enable: %d\n", regs->interrupt_status_enable); - TRACE("interrupt_signal_enable: %d\n", regs->interrupt_signal_enable); + TRACE("interrupt_status: %x enable: %x signal: %x\n", + regs->interrupt_status, regs->interrupt_status_enable, + regs->interrupt_signal_enable); TRACE("auto_cmd12_error_status: %d\n", regs->auto_cmd12_error_status); TRACE("capabilities: %d\n", regs->capabilities); TRACE("capabilities_rsvd: %d\n", regs->capabilities_rsvd); @@ -90,7 +87,7 @@ sdhci_register_dump(uint8_t slot, struct registers* regs) TRACE("max_current_capabilities_rsvd: %d\n", regs->max_current_capabilities_rsvd); TRACE("slot_interrupt_status: %d\n", regs->slot_interrupt_status); - TRACE("host_control_version %d\n", regs->host_control_version); + TRACE("host_control_version %x\n", regs->host_control_version); }