i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[hey] - Fix overflow issue found by LGTM

Browse Source 
LGTM issue: "gets does not guard against buffer overflow"

Change-Id: I502428f167865ac81301aa72d20c91b4480fb3dc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1926
Reviewed-by: Adrien Destugues <[email protected]>
This commit is contained in:
CodeforEvolution
2019-11-14 16:57:06 +00:00
committed by Jérôme Duval
parent 0156f4ffef
commit 89fc6d6aa2
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bin/hey.cpp
+5 -2
View File
@@ -126,6 +126,9 @@ bool is_valid_char(uint8 c);
const char VERSION[] = "v1.2.8"; const char VERSION[] = "v1.2.8";
#define MAX_INPUT_SIZE 1024
// Maximum amount of input data that "hey" can process at a time
#define DEBUG_HEY 0 // 1: prints the script message to be sent to the target application, 0: prints only the reply #define DEBUG_HEY 0 // 1: prints the script message to be sent to the target application, 0: prints only the reply
@@ -338,10 +341,10 @@ HeyInterpreterThreadHook(void* arg)
if (environment.HasMessenger("Target")) if (environment.HasMessenger("Target"))
environment.FindMessenger("Target", &target); environment.FindMessenger("Target", &target);
char command[1024]; char command[MAX_INPUT_SIZE];
status_t err; status_t err;
BMessage reply; BMessage reply;
while (gets(command)) { while (fgets(command, sizeof(command), stdin)) {
reply.MakeEmpty(); reply.MakeEmpty();
err = Hey(&target, command, &reply); err = Hey(&target, command, &reply);
if (!err) { if (!err) {