From 8a8e01bf41c7dd1bae381967e31177ef161357da Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Wed, 19 Dec 2018 20:06:19 +0900 Subject: [PATCH] strfmon.c: Fix -Wpointer-compare Fix comparison between pointer and zero character constant. Pointed out by gcc7. See also: https://github.com/freebsd/freebsd/commit/3d4c1b73b9036a1d5455a4a63eba6e0d20be9350 Change-Id: I917ceefce69e269fbaa12a3ae60f0702f5c5d4a7 Reviewed-on: https://review.haiku-os.org/782 Reviewed-by: Adrien Destugues --- src/system/libroot/posix/stdlib/strfmon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/system/libroot/posix/stdlib/strfmon.c b/src/system/libroot/posix/stdlib/strfmon.c index 25f0c30c9c..c2b97e68f6 100644 --- a/src/system/libroot/posix/stdlib/strfmon.c +++ b/src/system/libroot/posix/stdlib/strfmon.c @@ -414,7 +414,7 @@ __setup_vars(int flags, char *cs_precedes, char *sep_by_space, char *sign_posn, *cs_precedes = lc->int_n_cs_precedes; *sep_by_space = lc->int_n_sep_by_space; *sign_posn = (flags & PARENTH_POSN) ? 0 : lc->int_n_sign_posn; - *signstr = (lc->negative_sign == '\0') ? "-" : lc->negative_sign; + *signstr = (lc->negative_sign[0] == '\0') ? "-" : lc->negative_sign; } else if (flags & USE_INTL_CURRENCY) { *cs_precedes = lc->int_p_cs_precedes; *sep_by_space = lc->int_p_sep_by_space; @@ -424,7 +424,7 @@ __setup_vars(int flags, char *cs_precedes, char *sep_by_space, char *sign_posn, *cs_precedes = lc->n_cs_precedes; *sep_by_space = lc->n_sep_by_space; *sign_posn = (flags & PARENTH_POSN) ? 0 : lc->n_sign_posn; - *signstr = (lc->negative_sign == '\0') ? "-" : lc->negative_sign; + *signstr = (lc->negative_sign[0] == '\0') ? "-" : lc->negative_sign; } else { *cs_precedes = lc->p_cs_precedes; *sep_by_space = lc->p_sep_by_space;