BMediaNode API is now feature complete

* Change BMediaNode::GetNodeAttributes macro to CALLED(),
  since the base implementation should just return B_ERROR,
  unset as unimplemented for consistency.
* This means that since the latest changes the class
  is now feature complete and implements the whole R5 API.
* Add documentation comment for it as well.
* Fix some lines going over 80 chars.
This commit is contained in:
Dario Casalinuovo
2015-07-12 13:58:44 +02:00
parent 32e484046d
commit 8abf9450f0
+13 -7
View File
@@ -139,8 +139,10 @@ BMediaNode::~BMediaNode()
if ((fKinds & NODE_KIND_SHADOW_TIMESOURCE) == 0) { if ((fKinds & NODE_KIND_SHADOW_TIMESOURCE) == 0) {
if (fControlPort > 0) if (fControlPort > 0)
delete_port(fControlPort); delete_port(fControlPort);
} else } else {
TRACE("BMediaNode::~BMediaNode: shadow timesource, not unregistering\n"); TRACE("BMediaNode::~BMediaNode: shadow timesource,"
" not unregistering\n");
}
} }
@@ -787,7 +789,8 @@ status_t
BMediaNode::RequestCompleted(const media_request_info& info) BMediaNode::RequestCompleted(const media_request_info& info)
{ {
CALLED(); CALLED();
// This function is called whenever a request issued by the node is completed. // This function is called whenever
// a request issued by the node is completed.
// May be overriden by derived classes. // May be overriden by derived classes.
// info.change_tag can be used to match up requests against // info.change_tag can be used to match up requests against
// the accompaning calles from // the accompaning calles from
@@ -816,7 +819,8 @@ void
BMediaNode::NodeRegistered() BMediaNode::NodeRegistered()
{ {
CALLED(); CALLED();
// The Media Server calls this hook function after the node has been registered. // The Media Server calls this hook function
// after the node has been registered.
// May be overriden by derived classes. // May be overriden by derived classes.
} }
@@ -825,8 +829,9 @@ status_t
BMediaNode::GetNodeAttributes(media_node_attribute* outAttributes, BMediaNode::GetNodeAttributes(media_node_attribute* outAttributes,
size_t inMaxCount) size_t inMaxCount)
{ {
UNIMPLEMENTED(); CALLED();
// This is implemented by derived classes that fills
// it's own attributes to a max of inMaxCount size.
return B_ERROR; return B_ERROR;
} }
@@ -926,7 +931,8 @@ BMediaNode::IncrementChangeTag()
CALLED(); CALLED();
// Only present in BeOS R4 // Only present in BeOS R4
// Obsoleted in BeOS R4.5 and later // Obsoleted in BeOS R4.5 and later
// "updates the change tag, so that downstream consumers know that the node is in a new state." // "updates the change tag, so that downstream consumers
// know that the node is in a new state."
// not supported, only for binary compatibility // not supported, only for binary compatibility
return 0; return 0;
} }