From 8b9ec556063d1972bf54ff0e71b994a46683d290 Mon Sep 17 00:00:00 2001 From: Michael Lotz Date: Sat, 5 Sep 2015 15:56:19 +0200 Subject: [PATCH] BPicture: Fix archive constructor. The cleanup commit df48d3f9a839a18e16b3d7036935bef621b4fbb6 broke constructing a BPicture from an archive due to an incomplete rename. The passed in BMessage was used as the data buffer instead of the extracted data field. Fixes the application side crash of #12340. Seeing how long this was broken without anyone noticing, the feature doesn't seem to be very popular. --- src/kits/interface/Picture.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kits/interface/Picture.cpp b/src/kits/interface/Picture.cpp index 064a51ab15..3e130bf1aa 100644 --- a/src/kits/interface/Picture.cpp +++ b/src/kits/interface/Picture.cpp @@ -184,7 +184,7 @@ BPicture::BPicture(BMessage* data) // TODO: For now. We'll see if it's worth to support old style data debugger("old style BPicture data is not supported"); } else if (version == 1) { - fExtent->ImportData(data, size); + fExtent->ImportData(pictureData, size); // swap_data(fExtent->fNewData, fExtent->fNewSize);