From 8c9dc662ee6b7fbf660534952b81aa9b77e27099 Mon Sep 17 00:00:00 2001 From: Alexander von Gluck IV Date: Thu, 28 Jan 2021 18:56:29 -0600 Subject: [PATCH] boot/platform/efi: Don't 'enable' graphics mode; solves #16753 * Console-control is non-standard, but is needed on older Apple hardware to transition their EFI bioses to text-mode so our bootloader menu can be used / seen. * Console-control seems to exist on some older Intel hardware as well. Enabling it breaks our keyboard support. (maybe when enabled a different legacy UEFI call needs used to input or something) * Instead of trying to use a deprecated EFI call in a meaningful way, just do the "bare minimum" of disabling it when it exists. Change-Id: I20c3e026e02996371f632361c6899532c195bbf8 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3685 Reviewed-by: Adrien Destugues --- src/system/boot/platform/efi/console.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/system/boot/platform/efi/console.cpp b/src/system/boot/platform/efi/console.cpp index 5747436632..f83428b534 100644 --- a/src/system/boot/platform/efi/console.cpp +++ b/src/system/boot/platform/efi/console.cpp @@ -249,7 +249,10 @@ console_control(bool graphics) status_t console_init(void) { - console_control(true); + // Solves video issues on Apple hardware. This is non-standard and + // deprecated and should not be used for anything else! + console_control(false); + update_screen_size(); console_hide_cursor(); console_clear_screen();