From 8d50f4a5986f158edfe75c8280305aeab2735a65 Mon Sep 17 00:00:00 2001 From: Rene Gollent Date: Sat, 31 Jul 2010 18:39:34 +0000 Subject: [PATCH] NewModelItem can potentially return NULL in a number of cases, which wasn't checked for. Don't try to add them or otherwise manipulate them in such a case. Fixes CID 641. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37828 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/kits/tracker/FavoritesMenu.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/kits/tracker/FavoritesMenu.cpp b/src/kits/tracker/FavoritesMenu.cpp index bf3a8aefb0..60a5362b10 100644 --- a/src/kits/tracker/FavoritesMenu.cpp +++ b/src/kits/tracker/FavoritesMenu.cpp @@ -165,6 +165,9 @@ FavoritesMenu::AddNextItem() BMenuItem *item = BNavMenu::NewModelItem(&model, model.IsDirectory() ? fOpenFolderMessage : fOpenFileMessage, fTarget); + + if (item == NULL) + return true; item->SetLabel(ref.name); // this is the name of the link in the Go dir