From 8d721650cecad11fd6468804c9bd8ecb043aad09 Mon Sep 17 00:00:00 2001 From: JackBurton79 Date: Thu, 16 Aug 2018 15:46:17 +0200 Subject: [PATCH] Check for NULL before dereferencing fStream pointer. Change-Id: Ic1c21b24a3a1c02b478d1e8b2e395cc8a4e7adab --- src/add-ons/media/plugins/ffmpeg/AVFormatWriter.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/add-ons/media/plugins/ffmpeg/AVFormatWriter.cpp b/src/add-ons/media/plugins/ffmpeg/AVFormatWriter.cpp index 3fc7df357e..61e4c14a77 100644 --- a/src/add-ons/media/plugins/ffmpeg/AVFormatWriter.cpp +++ b/src/add-ons/media/plugins/ffmpeg/AVFormatWriter.cpp @@ -106,13 +106,14 @@ AVFormatWriter::StreamCookie::Init(media_format* format, fPacket.stream_index = fFormatContext->nb_streams; fStream = avformat_new_stream(fFormatContext, NULL); - fStream->id = fPacket.stream_index; if (fStream == NULL) { TRACE(" failed to add new stream\n"); return B_ERROR; } + fStream->id = fPacket.stream_index; + // TRACE(" fStream->codecpar: %p\n", fStream->codecpar); // TODO: This is a hack for now! Use avcodec_find_encoder_by_name() // or something similar...