From 8edf74fa651350ce248d7eb9974ab6a1a0e6037d Mon Sep 17 00:00:00 2001 From: John Scipione Date: Fri, 27 Jun 2014 22:36:16 -0400 Subject: [PATCH] MidiPlayer: Update version to 1.0.1 final Change the BAlert about box into a BAboutWindow. Add Authors based on commit logs. Unfortunately the description contained: "Haiku MIDI Player 1.0.0 beta\n\n" which means that it is going to get flagged for re-translation, sorry! This was bound to happen when the version number changed, on the bright side it shouldn't happen again in the future since the Name and version number are separate. --- src/apps/midiplayer/Jamfile | 2 ++ src/apps/midiplayer/MidiPlayer.rdef | 6 ++--- src/apps/midiplayer/MidiPlayerApp.cpp | 38 +++++++++++++++++++++------ 3 files changed, 35 insertions(+), 11 deletions(-) diff --git a/src/apps/midiplayer/Jamfile b/src/apps/midiplayer/Jamfile index 3d75d96d6d..7e7788a3fd 100644 --- a/src/apps/midiplayer/Jamfile +++ b/src/apps/midiplayer/Jamfile @@ -2,6 +2,8 @@ SubDir HAIKU_TOP src apps midiplayer ; SetSubDirSupportedPlatformsBeOSCompatible ; +UsePrivateHeaders interface ; + Application MidiPlayer : MidiPlayerApp.cpp MidiPlayerWindow.cpp diff --git a/src/apps/midiplayer/MidiPlayer.rdef b/src/apps/midiplayer/MidiPlayer.rdef index a8fc493497..1befb7cec4 100644 --- a/src/apps/midiplayer/MidiPlayer.rdef +++ b/src/apps/midiplayer/MidiPlayer.rdef @@ -4,10 +4,10 @@ resource app_signature "application/x-vnd.Haiku-MidiPlayer"; resource app_name_catalog_entry "x-vnd.Haiku-MidiPlayer:System name:MidiPlayer"; resource app_version { - major = 1, + major = 1, middle = 0, - minor = 0, - variety = B_APPV_BETA, + minor = 1, + variety = B_APPV_FINAL, internal = 0, short_info = "MidiPlayer", long_info = "MidiPlayer Copyright (c) 2004 Matthijs Hollemans, " diff --git a/src/apps/midiplayer/MidiPlayerApp.cpp b/src/apps/midiplayer/MidiPlayerApp.cpp index c4309a9eef..74dda5ccc3 100644 --- a/src/apps/midiplayer/MidiPlayerApp.cpp +++ b/src/apps/midiplayer/MidiPlayerApp.cpp @@ -58,16 +58,38 @@ MidiPlayerApp::ReadyToRun() void MidiPlayerApp::AboutRequested() { - BAlert* alert = new BAlert(NULL, - B_TRANSLATE_COMMENT("Haiku MIDI Player 1.0.0 beta\n\n" + BAboutWindow* window = new BAboutWindow("MidiPlayer", + MIDI_PLAYER_SIGNATURE); + + const char* extraCopyrights[] = { + "2008-2014 Haiku, Inc.", + NULL + }; + window->AddCopyright(2004, "Matthijs Hollemans", extraCopyrights); + + const char* authors[] = { + "Adrien Destugues", + "Axel Dörfler", + "Matthijs Hollemans", + "Humdinger", + "Ryan Leavengood", + "Matt Madia", + "John Scipione", + "Jonas Sundström", + "Oliver Tappe", + NULL + }; + window->AddAuthors(authors); + + window->AddDescription(B_TRANSLATE_COMMENT( "This tiny program\n" "Knows how to play thousands of\n" - "Cheesy sounding songs", "This is a haiku. First line has five " - "syllables, second has seven and last has five again. " - "Create your own."), B_TRANSLATE("OK"), NULL, NULL, - B_WIDTH_AS_USUAL, B_INFO_ALERT); - alert->SetFlags(alert->Flags() | B_CLOSE_ON_ESCAPE); - alert->Go(); + "Cheesy sounding songs", + "This is a haiku. First line has five syllables, " + "second has seven and last has five again. " + "Create your own.")); + + window->Show(); }