From 8f16f634d7f48fba2f801158e6fe6708dba97fbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Sun, 24 Aug 2014 18:10:24 +0200 Subject: [PATCH] MessageBuilder: Fix leaking BMessages. The initial message is not deleted, since the current message is not on the stack. --- src/kits/shared/MessageBuilder.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kits/shared/MessageBuilder.cpp b/src/kits/shared/MessageBuilder.cpp index 36f2651954..4ab8a84371 100644 --- a/src/kits/shared/MessageBuilder.cpp +++ b/src/kits/shared/MessageBuilder.cpp @@ -68,7 +68,9 @@ BMessageBuilder::PopObject() BMessage* previousMessage = fStack.LastItem(); previousMessage->AddMessage(fNameStack.LastItem()->String(), - fCurrentMessage); + fCurrentMessage); + + delete fCurrentMessage; fCurrentMessage = previousMessage; fStack.RemoveItemAt(fStack.CountItems() - 1);