i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

In the assignment operator, watch out if the passed message is ourself.

Browse Source 
Fixes a crash in WonderBrush when dragging images over the layer list
to import them and triggering auto-scrolling. WonderBrush caches the
drag message and appearantly calls it's own MouseMoved() hood with the
cached message from within the auto-scrolling code.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@29464 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus
2009-03-10 14:32:59 +00:00
parent ce8253d97b
commit 8f73c97d42
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/app/Message.cpp
+5 -2
View File
@@ -164,6 +164,9 @@ BMessage::operator=(const BMessage &other)
{ {
DEBUG_FUNCTION_ENTER; DEBUG_FUNCTION_ENTER;
if (this == &other)
return *this;
_Clear(); _Clear();
fHeader = (message_header *)malloc(sizeof(message_header)); fHeader = (message_header *)malloc(sizeof(message_header));
@@ -2080,8 +2083,8 @@ BMessage::_SendMessage(port_id port, team_id portOwner, int32 token,
fHeader->flags |= MESSAGE_FLAG_REPLY_DONE; fHeader->flags |= MESSAGE_FLAG_REPLY_DONE;
} }
// we need to do this last because it is possible our // we need to do this last because it is possible our
// message might be destroyed after it's enqueued in the // message might be destroyed after it's enqueued in the
// target looper. Thus we don't want to do any ops that depend on // target looper. Thus we don't want to do any ops that depend on
// members of this after the enqueue. // members of this after the enqueue.
if (direct != NULL) { if (direct != NULL) {