i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

strace: Trivial improvements.

Browse Source 
* Break in FlagsTypeHandler once we have cleared all flags.
 * Use sizeof(hex) instead of writing out the size again.
 * Place comment above variable name in patch_syscalls.
This commit is contained in:
Augustin Cavalier
2023-03-28 15:38:53 -04:00
parent 04acec35f9
commit 90b0629ee1
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bin/debug/strace/TypeHandler.cpp
+3 -1
View File
@@ -228,6 +228,8 @@ FlagsTypeHandler::RenderValue(Context &context, unsigned int value) const
string rendered; string rendered;
FlagsList::const_reverse_iterator i = fList.rbegin(); FlagsList::const_reverse_iterator i = fList.rbegin();
for (; i != fList.rend(); i++) { for (; i != fList.rend(); i++) {
if (value == 0)
break;
if ((value & i->value) != i->value) if ((value & i->value) != i->value)
continue; continue;
@@ -241,7 +243,7 @@ FlagsTypeHandler::RenderValue(Context &context, unsigned int value) const
rendered += " | "; rendered += " | ";
char hex[20]; char hex[20];
snprintf(hex, 20, "%x", value); snprintf(hex, sizeof(hex), "0x%x", value);
rendered += hex; rendered += hex;
} }
if (rendered.empty()) if (rendered.empty())
src/bin/debug/strace/strace.cpp
+2 -1
View File
@@ -272,8 +272,9 @@ patch_syscalls()
for (size_t i = 0; i < sSyscallVector.size(); i++) { for (size_t i = 0; i < sSyscallVector.size(); i++) {
Syscall *syscall = sSyscallVector[i]; Syscall *syscall = sSyscallVector[i];
const string returnTypeName = syscall->ReturnType()->TypeName();
// patch return type handlers // patch return type handlers
const string returnTypeName = syscall->ReturnType()->TypeName();
if (returnTypeName == "status_t" || returnTypeName == "ssize_t" if (returnTypeName == "status_t" || returnTypeName == "ssize_t"
|| returnTypeName == "int") { || returnTypeName == "int") {
syscall->ReturnType()->SetHandler(create_status_t_type_handler()); syscall->ReturnType()->SetHandler(create_status_t_type_handler());