i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* it should be better to lock before accessing the data, even if reading only

Browse Source 
* after this change, I have not spotted "left behind" cursors again, but it
  might just be bad luck...


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@21966 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus
2007-08-15 19:06:11 +00:00
parent 86d8381f5f
commit 91d0586a7d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/app/drawing/HWInterface.cpp
+3 -1
View File
@@ -382,18 +382,20 @@ HWInterface::HideOverlay(Overlay* overlay)
bool bool
HWInterface::HideSoftwareCursor(const BRect& area) HWInterface::HideSoftwareCursor(const BRect& area)
{ {
if (!fSoftwareCursorLock.Lock())
return false;
if (fCursorAreaBackup && !fCursorAreaBackup->cursor_hidden) { if (fCursorAreaBackup && !fCursorAreaBackup->cursor_hidden) {
BRect backupArea(fCursorAreaBackup->left, BRect backupArea(fCursorAreaBackup->left,
fCursorAreaBackup->top, fCursorAreaBackup->top,
fCursorAreaBackup->right, fCursorAreaBackup->right,
fCursorAreaBackup->bottom); fCursorAreaBackup->bottom);
if (area.Intersects(backupArea)) { if (area.Intersects(backupArea)) {
fSoftwareCursorLock.Lock();
_RestoreCursorArea(); _RestoreCursorArea();
// do not unlock the cursor lock // do not unlock the cursor lock
return true; return true;
} }
} }
fSoftwareCursorLock.Unlock();
return false; return false;
} }