From 93bd491fb75dd3b0d83d3fe99bc1ecfc8ad07934 Mon Sep 17 00:00:00 2001 From: Philippe Saint-Pierre Date: Wed, 1 Jul 2015 19:22:24 -0400 Subject: [PATCH] Logic error in TaskLoop::RunIfNeeded() The ! operator would have priority over < and would transform currentTime before the comparison. Moreso, the logic was reversed. It is supposed to return false if it's not time yet to run the task, not the opposite. CID 1273447. --- src/kits/tracker/TaskLoop.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kits/tracker/TaskLoop.cpp b/src/kits/tracker/TaskLoop.cpp index 122f440f25..482b09e03c 100644 --- a/src/kits/tracker/TaskLoop.cpp +++ b/src/kits/tracker/TaskLoop.cpp @@ -181,7 +181,7 @@ PeriodicDelayedTask::~PeriodicDelayedTask() bool PeriodicDelayedTask::RunIfNeeded(bigtime_t currentTime) { - if (!currentTime < fRunAfter) + if (currentTime < fRunAfter) return false; fRunAfter = currentTime + fPeriod;