i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* fixed broken FindLast() taking a char and an offset

Browse Source 
* added two more tests that exhibit the (now fixed) problem in FindLast()



git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16586 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Oliver Tappe
2006-03-05 18:27:50 +00:00
parent 0d4c16e0c0
commit 94a055c10d
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/support/String.cpp
+1 -1
View File
@@ -1318,7 +1318,7 @@ BString::FindLast(char c, int32 beforeOffset) const
return B_ERROR; return B_ERROR;
const char *start = String(); const char *start = String();
const char *end = String() + Length() - beforeOffset; const char *end = String() + beforeOffset;
/* Scans the string backwards until we found the character, */ /* Scans the string backwards until we found the character, */
/* or we reach the string's start */ /* or we reach the string's start */
src/tests/kits/support/bstring/StringSearchTest.cpp
+12
View File
@@ -249,6 +249,18 @@ StringSearchTest::PerformTest(void)
CPPUNIT_ASSERT(i == B_ERROR); CPPUNIT_ASSERT(i == B_ERROR);
delete string1; delete string1;
NextSubTest();
string1 = new BString("abcd abcd");
i = string1->FindLast('b', 6);
CPPUNIT_ASSERT(i == 6);
delete string1;
NextSubTest();
string1 = new BString("abcd abcd");
i = string1->FindLast('b', 5);
CPPUNIT_ASSERT(i == 1);
delete string1;
NextSubTest(); NextSubTest();
string1 = new BString("abc abc abc"); string1 = new BString("abc abc abc");
i = string1->FindLast("a", 0); i = string1->FindLast("a", 0);