From 95a5e62515808b415511be61fc318e627141f9b0 Mon Sep 17 00:00:00 2001 From: Dario Casalinuovo Date: Wed, 7 Sep 2016 18:02:34 +0200 Subject: [PATCH] MediaFile: Correctly delete the source on exit * The delete flag of BUrl constructors was reset by _Init, this lead to a zombie thread on the background under certain conditions. --- src/kits/media/MediaFile.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kits/media/MediaFile.cpp b/src/kits/media/MediaFile.cpp index 447ab3aea0..ec02f08937 100644 --- a/src/kits/media/MediaFile.cpp +++ b/src/kits/media/MediaFile.cpp @@ -85,8 +85,8 @@ BMediaFile::BMediaFile(const media_file_format* mfi, int32 flags) BMediaFile::BMediaFile(const BUrl& url) { CALLED(); - fDeleteSource = true; _Init(); + fDeleteSource = true; _InitReader(NULL, &url); } @@ -94,8 +94,8 @@ BMediaFile::BMediaFile(const BUrl& url) BMediaFile::BMediaFile(const BUrl& url, int32 flags) { CALLED(); - fDeleteSource = true; _Init(); + fDeleteSource = true; _InitReader(NULL, &url, flags); } @@ -104,8 +104,8 @@ BMediaFile::BMediaFile(BUrl destination, const media_file_format* mfi, int32 flags) { CALLED(); - fDeleteSource = true; _Init(); + fDeleteSource = true; _InitWriter(NULL, &destination, mfi, flags); // TODO: Implement streaming server support, it's // a pretty complex thing compared to client mode