From 963681995c2ac62a4373e34ab4b251ddbe57f5c4 Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Wed, 29 Nov 2023 20:59:05 +0900 Subject: [PATCH] file_systems/fat: Fix duplicateExpression Pointed out by cppcheck Change-Id: I21314d0724fd1b7ae74c575197aa3b50fb75db55 Reviewed-on: https://review.haiku-os.org/c/haiku/+/7256 Tested-by: Commit checker robot Reviewed-by: Adrien Destugues --- src/add-ons/kernel/file_systems/fat/file.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/kernel/file_systems/fat/file.cpp b/src/add-ons/kernel/file_systems/fat/file.cpp index 8c31fcfe9e..5781cac2e9 100644 --- a/src/add-ons/kernel/file_systems/fat/file.cpp +++ b/src/add-ons/kernel/file_systems/fat/file.cpp @@ -687,7 +687,7 @@ dosfs_mkdir(fs_volume *_vol, fs_vnode *_dir, const char *name, int perms) } dummy.end_cluster = dummy.cluster; dummy.mode = FAT_SUBDIR; - if (!(perms & (S_IWUSR | S_IWGRP | S_IWGRP))) { + if (!(perms & (S_IWUSR | S_IWGRP | S_IWOTH))) { dummy.mode |= FAT_READ_ONLY; } dummy.st_size = vol->bytes_per_sector*vol->sectors_per_cluster;