i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

PluginManager: Fix memory leak.

Browse Source 
* Fixes #13126.
This commit is contained in:
Dario Casalinuovo
2017-03-10 02:00:36 +01:00
parent 5854fc4a7a
commit 98f2303da5
1 changed files with 4 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/media/PluginManager.cpp
+4 -11
View File
@@ -6,6 +6,7 @@
#include <AdapterIO.h> #include <AdapterIO.h>
#include <AutoDeleter.h>
#include <Autolock.h> #include <Autolock.h>
#include <BufferIO.h> #include <BufferIO.h>
#include <DataIO.h> #include <DataIO.h>
@@ -190,13 +191,6 @@ public:
return fPosition->GetSize(size); return fPosition->GetSize(size);
} }
// Utility methods
status_t InitCheck() const
{
return fErr;
}
protected: protected:
bool IsMedia() const bool IsMedia() const
@@ -235,15 +229,13 @@ PluginManager::CreateReader(Reader** reader, int32* streamCount,
// way, we create an instance which is buffering our reads and // way, we create an instance which is buffering our reads and
// writes. // writes.
BMediaIOWrapper* buffered_source = new BMediaIOWrapper(source); BMediaIOWrapper* buffered_source = new BMediaIOWrapper(source);
status_t ret = buffered_source->InitCheck(); ObjectDeleter<BMediaIOWrapper> ioDeleter(buffered_source);
if (ret != B_OK)
return ret;
// get list of available readers from the server // get list of available readers from the server
entry_ref refs[MAX_READERS]; entry_ref refs[MAX_READERS];
int32 count; int32 count;
ret = AddOnManager::GetInstance()->GetReaders(refs, &count, status_t ret = AddOnManager::GetInstance()->GetReaders(refs, &count,
MAX_READERS); MAX_READERS);
if (ret != B_OK) { if (ret != B_OK) {
printf("PluginManager::CreateReader: can't get list of readers: %s\n", printf("PluginManager::CreateReader: can't get list of readers: %s\n",
@@ -282,6 +274,7 @@ PluginManager::CreateReader(Reader** reader, int32* streamCount,
TRACE("PluginManager::CreateReader: Sniff success " TRACE("PluginManager::CreateReader: Sniff success "
"(%" B_PRId32 " stream(s))\n", *streamCount); "(%" B_PRId32 " stream(s))\n", *streamCount);
(*reader)->GetFileFormatInfo(mff); (*reader)->GetFileFormatInfo(mff);
ioDeleter.Detach();
return B_OK; return B_OK;
} }