From 998ef890654e102c89634fbc9e40eb605878542f Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Tue, 13 Aug 2013 14:43:29 +0200 Subject: [PATCH] package daemon: Volume: fix package removal after transaction Volume::_ChangePackageActivation(): Refactoring oversight: fPackagesToBeDeactivated was still used instead of the packagesToDeactivate parameter, so the packages wouldn't be removed from the hash tables when invoked from the CommitTransactionHandler. Fixes #9921. --- src/servers/package/Volume.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/servers/package/Volume.cpp b/src/servers/package/Volume.cpp index 919dcb849d..fc0dbad8c2 100644 --- a/src/servers/package/Volume.cpp +++ b/src/servers/package/Volume.cpp @@ -1721,8 +1721,8 @@ packagesToActivate.size(), packagesToDeactivate.size()); fChangeCount++; } - for (PackageSet::iterator it = fPackagesToBeDeactivated.begin(); - it != fPackagesToBeDeactivated.end(); ++it) { + for (PackageSet::iterator it = packagesToDeactivate.begin(); + it != packagesToDeactivate.end(); ++it) { Package* package = *it; _RemovePackage(package); delete package;