From 99f9333a2a6f17c91995afaf74c4e120862d3d4c Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Tue, 10 Sep 2013 19:01:25 +0200 Subject: [PATCH] BPackageManager::_CommitPackageChanges(): Fix error handling The error returned by CommitTransaction() is just indicates whether transactionResult has been initialized. --- src/kits/package/manager/PackageManager.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/kits/package/manager/PackageManager.cpp b/src/kits/package/manager/PackageManager.cpp index bba220c704..b61cc4297c 100644 --- a/src/kits/package/manager/PackageManager.cpp +++ b/src/kits/package/manager/PackageManager.cpp @@ -518,7 +518,9 @@ BPackageManager::_CommitPackageChanges(Transaction& transaction) BDaemonClient::BCommitTransactionResult transactionResult; status_t error = fInstallationInterface->CommitTransaction(transaction, transactionResult); - if (error != B_OK) { + if (error != B_OK) + DIE(error, "failed to commit transaction"); + if (transactionResult.Error() != B_OK) { DIE("failed to commit transaction: %s", transactionResult.FullErrorMessage().String()); }