i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bus_managers/firewire: Fix warnings

Browse Source 
Add parenthesis for macro processing, change variable type for signedness comparison warning

Change-Id: I67125ac1dfc97583ecb9e5706909a0a09cda7a2e
Reviewed-on: https://review.haiku-os.org/c/haiku/+/4575
Reviewed-by: Adrien Destugues <[email protected]>
This commit is contained in:
Franck LeCodeur
2021-10-20 18:00:36 +00:00
committed by waddlesplash
parent 718fce997a
commit 9a594d0a60
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/firewire/firewire.cpp
+2 -2
View File
@@ -1107,7 +1107,7 @@ fw_tl2xfer(struct firewire_comm *fc, int node, int tlabel, int tcode)
if((uint)xfer->send.hdr.mode.hdr.dst == (uint)node) { if((uint)xfer->send.hdr.mode.hdr.dst == (uint)node) {
mtx_unlock(&fc->tlabel_lock); mtx_unlock(&fc->tlabel_lock);
splx(s); splx(s);
KASSERT(xfer->tl == tlabel, KASSERT((xfer->tl == tlabel),
("xfer->tl 0x%x != 0x%x", xfer->tl, tlabel)); ("xfer->tl 0x%x != 0x%x", xfer->tl, tlabel));
/* extra sanity check */ /* extra sanity check */
req = xfer->send.hdr.mode.hdr.tcode; req = xfer->send.hdr.mode.hdr.tcode;
@@ -2102,7 +2102,7 @@ fw_rcv(struct fw_rcv_buf *rb)
if(bind == NULL){ if(bind == NULL){
device_printf(rb->fc->bdev, "%s: " device_printf(rb->fc->bdev, "%s: "
"Unknown service addr 0x%04x:0x%08x %s(%x)" "Unknown service addr 0x%04x:0x%08x %s(%x)"
" src=0x%x data=%u\n", " src=0x%x data=%" B_PRIu32 "\n",
__func__, __func__,
fp->mode.wreqq.dest_hi, fp->mode.wreqq.dest_hi,
fp->mode.wreqq.dest_lo, fp->mode.wreqq.dest_lo,
src/bin/fwcontrol/fwcrom.c
+3 -3
View File
@@ -465,15 +465,15 @@ crom_add_simple_text(struct crom_src *src, struct crom_chunk *parent,
{ {
struct csrtext *tl; struct csrtext *tl;
uint32_t *p; uint32_t *p;
int len, i; size_t len, i;
char t[MAX_TEXT]; char t[MAX_TEXT];
len = strlen(buf); len = strlen(buf);
if (len > MAX_TEXT) { if (len > MAX_TEXT) {
#if defined(__DragonFly__) || __FreeBSD_version < 500000 #if defined(__DragonFly__) || __FreeBSD_version < 500000
printf("text(%d) truncated to %zd.\n", len, MAX_TEXT); printf("text(%zu) truncated to %zu.\n", len, MAX_TEXT);
#else #else
printf("text(%d) truncated to %zd.\n", len, MAX_TEXT); printf("text(%zu) truncated to %zu.\n", len, MAX_TEXT);
#endif #endif
len = MAX_TEXT; len = MAX_TEXT;
} }