diff --git a/headers/private/graphics/nvidia/DriverInterface.h b/headers/private/graphics/nvidia/DriverInterface.h index e013091bae..e61aaad187 100644 --- a/headers/private/graphics/nvidia/DriverInterface.h +++ b/headers/private/graphics/nvidia/DriverInterface.h @@ -89,12 +89,16 @@ enum { #define NV10_CONTEXT_SURFACES_2D 0x00000010 /* 2D */ #define NV1_IMAGE_FROM_CPU 0x00000010 /* 2D: unused, remove? */ #define NV_IMAGE_BLIT 0x00000011 /* 2D */ -//fixme: lose NV3_GDI_RECTANGLE_TEXT later on? DMA does not work with it.. -//non-dma: +/* fixme: + * never use NV3_GDI_RECTANGLE_TEXT for DMA acceleration: + * There's a hardware fault in the input->output colorspace conversion here. + * Besides, in NV40 and up this command nolonger exists. Both 'facts' are confirmed + * by testing. + * Note: + * There's no (big) speed difference between NV3_GDI_RECTANGLE_TEXT and + * NV4_GDI_RECTANGLE_TEXT (tested with BeRoMeter 1.2.6). */ #define NV3_GDI_RECTANGLE_TEXT 0x00000012 /* 2D */ -//dma: #define NV4_GDI_RECTANGLE_TEXT 0x00000012 /* 2D */ -//end fixme. #define NV_RENDER_D3D0_TRIANGLE_ZETA 0x00000013 /* unused (yet?) */ #define NV4_DX5_TEXTURE_TRIANGLE 0x00000014 /* 3D */ #define NV10_DX5_TEXTURE_TRIANGLE 0x00000014 /* 3D */ diff --git a/headers/private/graphics/nvidia/nv_acc.h b/headers/private/graphics/nvidia/nv_acc.h index 488b0f0de4..430042b3da 100644 --- a/headers/private/graphics/nvidia/nv_acc.h +++ b/headers/private/graphics/nvidia/nv_acc.h @@ -306,6 +306,7 @@ typedef struct { #define NV_IMAGE_PATTERN_SETCOLOR0 0x0310 #define NV_IMAGE_BLIT_SOURCEORG 0x0300 //fixme note: non-DMA acc is still using NV3_GDI_RECTANGLE_TEXT... +//which is just as fast as NV4_GDI_RECTANGLE_TEXT, but has a hardware fault for DMA! #define NV4_GDI_RECTANGLE_TEXT_SETCOLORFORMAT 0x0300 #define NV4_GDI_RECTANGLE_TEXT_COLOR1A 0x03fc #define NV4_GDI_RECTANGLE_TEXT_UCR0_LEFTTOP 0x0400