i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

XHCI: Trace an error when we receive command events for unknown commands.

Browse Source 
This revealed that StopEndpoint commands on QEMU were returning ...
after the semaphore timeout was already hit. Now to figure out
why that is the case...
This commit is contained in:
Augustin Cavalier
2019-07-14 14:31:07 -04:00
parent 60f15f5aa2
commit 9cd2907d68
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/busses/usb/xhci.cpp
+4 -1
View File
@@ -2332,7 +2332,8 @@ XHCI::HandleCmdComplete(xhci_trb* trb)
fCmdResult[0] = trb->status; fCmdResult[0] = trb->status;
fCmdResult[1] = B_LENDIAN_TO_HOST_INT32(trb->flags); fCmdResult[1] = B_LENDIAN_TO_HOST_INT32(trb->flags);
release_sem_etc(fCmdCompSem, 1, B_DO_NOT_RESCHEDULE); release_sem_etc(fCmdCompSem, 1, B_DO_NOT_RESCHEDULE);
} } else
TRACE_ERROR("received command event for unknown command!\n")
} }
@@ -2459,6 +2460,7 @@ XHCI::DoCommand(xhci_trb* trb)
if (acquire_sem_etc(fCmdCompSem, 1, B_RELATIVE_TIMEOUT, 1 * 1000 * 1000) < B_OK) { if (acquire_sem_etc(fCmdCompSem, 1, B_RELATIVE_TIMEOUT, 1 * 1000 * 1000) < B_OK) {
TRACE("Unable to obtain fCmdCompSem!\n"); TRACE("Unable to obtain fCmdCompSem!\n");
fCmdAddr = 0;
Unlock(); Unlock();
return B_TIMED_OUT; return B_TIMED_OUT;
} }
@@ -2483,6 +2485,7 @@ XHCI::DoCommand(xhci_trb* trb)
TRACE("Storing trb 0x%08" B_PRIx32 " 0x%08" B_PRIx32 "\n", trb->status, TRACE("Storing trb 0x%08" B_PRIx32 " 0x%08" B_PRIx32 "\n", trb->status,
trb->flags); trb->flags);
fCmdAddr = 0;
Unlock(); Unlock();
return status; return status;
} }