From 9d18e521912c94c839a2c0bec57bca5c681dd030 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Duval?= <jerome.duval@gmail.com>
Date: Fri, 26 Jul 2024 17:20:40 +0200
Subject: [PATCH] kernel: newGroups was allocated with malloc, deallocate with
 free()

fix gcc analyzer warning

Change-Id: I0427a3d9b288e081055242fff59f2e15e478dac6
Reviewed-on: https://review.haiku-os.org/c/haiku/+/7904
Reviewed-by: waddlesplash <waddlesplash@gmail.com>
Haiku-Format: Haiku-format Bot <no-reply+haikuformatbot@haiku-os.org>
---
 src/system/kernel/usergroup.cpp | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/system/kernel/usergroup.cpp b/src/system/kernel/usergroup.cpp
index 631d98c06d..9383f45cc3 100644
--- a/src/system/kernel/usergroup.cpp
+++ b/src/system/kernel/usergroup.cpp
@@ -224,9 +224,8 @@ common_setgroups(int groupCount, const gid_t* groupList, bool kernel)
 			memcpy(newGroups->groups, groupList, sizeof(gid_t) * groupCount);
 		} else {
 			if (!IS_USER_ADDRESS(groupList)
-				|| user_memcpy(newGroups->groups, groupList,
-					sizeof(gid_t) * groupCount) != B_OK) {
-				delete newGroups;
+				|| user_memcpy(newGroups->groups, groupList, sizeof(gid_t) * groupCount) != B_OK) {
+				free(newGroups);
 				return B_BAD_ADDRESS;
 			}
 		}