Adding the Quick Tour

* Add a link to the Quick Tour to the desktop.
* Remove the Welcome page from desktop. We don't want to clutter
  the user's desktop more than necessary. As "Home" page of
  WebPositive, it's still very visible.
* Mention the Quick Tour in the Welcome package description.
* Add a "quicktour" script similar to the welcome/userguide
  that opens the online version if it's not installed locally.
* Add icons to the userguide and quicktour scripts. Fixes #14706.
* Add bookmark and launcher for the Quick Tour.

Adjust the AddFileDataAttributeRule to create its temporary file in
the "common" architecture, the file is not architecture specific.

Add a rule PrepareScriptWithIcon in src/data/bin/Jamfile to assign
an icon and make the script executable.

Change-Id: Ia7604ff4715a5aaf9a645c1b3333a954d6a4dafc
Reviewed-on: https://review.haiku-os.org/c/haiku/+/1924
Reviewed-by: Adrien Destugues <[email protected]>

build/jam/BeOSRules

@@ -24,7 +24,7 @@ rule AddFileDataAttribute target : attrName : attrType : dataFile
 
 	ATTRIBUTE_NAME on $(attrMetaFile) = $(attrName) ;
 	ATTRIBUTE_TYPE on $(attrMetaFile) = $(attrType) ;
-	MakeLocateArch $(attrMetaFile) ;
+	MakeLocateCommonPlatform $(attrMetaFile) ;
 	CreateAttributeMetaFile $(attrMetaFile) ;
 
 	Depends $(target) : <build>addattr $(attrMetaFile) $(dataFile) ;

build/jam/OptionalPackages

@@ -184,8 +184,9 @@ if [ IsOptionalHaikuImagePackageAdded Welcome ] {
 
 	AddPackageFilesToHaikuImage system : haiku_welcome.hpkg : nameFromMetaInfo ;
 
-	AddSymlinkToHaikuImage home Desktop	: /boot/system/bin/welcome
-		: Welcome ;
+	AddSymlinkToHaikuImage home Desktop	: /boot/system/bin/quicktour
+		: Quick\ Tour ;
+
 	AddSymlinkToHaikuImage home Desktop	: /boot/system/bin/userguide
 		: User\ Guide ;
 }

build/jam/packages/HaikuWelcome

@@ -3,7 +3,9 @@ HaikuPackage $(haikuWelcomePackage) ;
 
 CopyDirectoryToPackage documentation : [ FDirName $(HAIKU_TOP) docs welcome ]
 	: welcome ;
+
 SEARCH on welcome = [ FDirName $(HAIKU_TOP) data bin ] ;
-AddFilesToPackage bin : welcome ;
+
+AddFilesToPackage bin : quicktour welcome ;
 
 BuildHaikuPackage $(haikuWelcomePackage) : haiku_welcome ;