From 9f9688d84193ead378c74290c54c74fbaed161fd Mon Sep 17 00:00:00 2001 From: PulkoMandy Date: Wed, 21 Dec 2022 14:10:38 +0100 Subject: [PATCH] media kit: avoid useless copy of entry_ref Copying an entry_ref is not cheap since the "name" field needs to be allocated and copied separately everytime. Here it is not needed at all, so let's just use a reference instead. Change-Id: I1e572b69569cbb7437db147b483779245ec5e180 --- src/kits/media/PluginManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kits/media/PluginManager.cpp b/src/kits/media/PluginManager.cpp index 89f786e5c6..28141358be 100644 --- a/src/kits/media/PluginManager.cpp +++ b/src/kits/media/PluginManager.cpp @@ -234,7 +234,7 @@ PluginManager::CreateReader(Reader** reader, int32* streamCount, // try each reader by calling it's Sniff function... for (int32 i = 0; i < count; i++) { - entry_ref ref = refs[i]; + const entry_ref& ref = refs[i]; MediaPlugin* plugin = GetPlugin(ref); if (plugin == NULL) { printf("PluginManager::CreateReader: GetPlugin failed\n");