nfs4: Check for semaphore creation errors in ConnectionBase classes

src/add-ons/kernel/file_systems/nfs4/CacheRevalidator.cpp

@@ -79,6 +79,7 @@ CacheRevalidator::_DirectoryCacheRevalidator()
 				B_RELATIVE_TIMEOUT,	DirectoryCache::kExpirationTime);
 
 			if (result != B_TIMED_OUT) {
+				if (result == B_OK)
 					release_sem(fWaitCancel);
 				return;
 			}
@@ -95,6 +96,7 @@ CacheRevalidator::_DirectoryCacheRevalidator()
 			status_t result = acquire_sem_etc(fWaitCancel, 1,
 				B_ABSOLUTE_TIMEOUT, current->ExpireTime());
 			if (result != B_TIMED_OUT) {
+				if (result == B_OK)
 					release_sem(fWaitCancel);
 				return;
 			}

src/add-ons/kernel/file_systems/nfs4/Connection.cpp

@@ -476,7 +476,14 @@ Connection::Connect(Connection **_connection, const PeerAddress& address)
 	if (conn == NULL)
 		return B_NO_MEMORY;
 
-	status_t result = conn->Connect();
+	status_t result;
+	if (conn->fWaitCancel < B_OK) {
+		result = conn->fWaitCancel;
+		delete conn;
+		return result;
+	}
+
+	result = conn->Connect();
 	if (result != B_OK) {
 		delete conn;
 		return result;
@@ -495,6 +502,14 @@ Connection::SetTo(Connection **_connection, int socket,
 	Connection* conn = CreateObject(address);
 	if (conn == NULL)
 		return B_NO_MEMORY;
+
+	status_t result;
+	if (conn->fWaitCancel < B_OK) {
+		result = conn->fWaitCancel;
+		delete conn;
+		return result;
+	}
+
 	conn->fSocket = socket;
 
 	*_connection = conn;
@@ -642,6 +657,14 @@ ConnectionListener::Listen(ConnectionListener** listener, uint16 port)
 		return B_NO_MEMORY;
 	}
 
+	status_t result;
+	if ((*listener)->fWaitCancel < B_OK) {
+		result = (*listener)->fWaitCancel;
+		close(sock);
+		delete *listener;
+		return result;
+	}
+
 	(*listener)->fSocket = sock;
 
 	return B_OK;

src/add-ons/kernel/file_systems/nfs4/NFS4Object.cpp

@@ -41,7 +41,9 @@ NFS4Object::HandleErrors(uint32 nfs4Error, RPC::Server* serv,
 					*sequence = fFileSystem->OpenOwnerSequenceLock();
 
 				return true;
-			} else if ((cookie->fMode & O_NONBLOCK) == 0) {
+			}
+
+			if ((cookie->fMode & O_NONBLOCK) == 0) {
 				status_t result = acquire_sem_etc(cookie->fSnoozeCancel, 1,
 					B_RELATIVE_TIMEOUT, sSecToBigTime(5));
 
@@ -49,6 +51,7 @@ NFS4Object::HandleErrors(uint32 nfs4Error, RPC::Server* serv,
 					*sequence = fFileSystem->OpenOwnerSequenceLock();
 
 				if (result != B_TIMED_OUT) {
+					if (result == B_OK)
 						release_sem(cookie->fSnoozeCancel);
 					return false;
 				}
@@ -71,7 +74,9 @@ NFS4Object::HandleErrors(uint32 nfs4Error, RPC::Server* serv,
 				if (sequence != NULL)
 					*sequence = fFileSystem->OpenOwnerSequenceLock();
 				return true;
-			} else if ((cookie->fMode & O_NONBLOCK) == 0) {
+			}
+
+			if ((cookie->fMode & O_NONBLOCK) == 0) {
 				status_t result = acquire_sem_etc(cookie->fSnoozeCancel, 1,
 					B_RELATIVE_TIMEOUT, sSecToBigTime(leaseTime) / 3);
 
@@ -79,6 +84,7 @@ NFS4Object::HandleErrors(uint32 nfs4Error, RPC::Server* serv,
 					*sequence = fFileSystem->OpenOwnerSequenceLock();
 
 				if (result != B_TIMED_OUT) {
+					if (result == B_OK)
 						release_sem(cookie->fSnoozeCancel);
 					return false;
 				}

src/add-ons/kernel/file_systems/nfs4/NFS4Server.cpp

@@ -231,6 +231,7 @@ NFS4Server::_Renewal()
 		status_t result = acquire_sem_etc(fWaitCancel, 1,
 			B_RELATIVE_TIMEOUT, sSecToBigTime(fLeaseTime - 2));
 		if (result != B_TIMED_OUT) {
+			if (result == B_OK)
 				release_sem(fWaitCancel);
 			return B_OK;
 		}