Cleanup while I was searching for a bug that ended up being in the app_server;

the decorators now return non-sense as their frame, thank you Clemens!
* Got rid of Settings::CurrentSettings() - the get/store pair wasn't really
  thread-safe anyway, as it always updated all fields, so settings could get
  lost easily. The mechanism is still being used in the settings window, though.
* Introduced some getters/setters for the settings that work on the message
  directly which simplifies some code.
* Minor style cleanups.
* Automatic whitespace cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@42732 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/apps/mediaplayer/MainWin.cpp

@@ -211,8 +211,7 @@ MainWin::MainWin(bool isFirstWindow, BMessage* message)
 	MoveBy(pos * 25, pos * 25);
 	pos = (pos + 1) % 15;
 
-	BRect frame = Settings::Default()->CurrentSettings()
-		.audioPlayerWindowFrame;
+	BRect frame = Settings::Default()->AudioPlayerWindowFrame();
 	if (frame.IsValid()) {
 		if (isFirstWindow) {
 			if (message == NULL) {
@@ -2585,8 +2584,8 @@ MainWin::_MarkItem(BMenu* menu, uint32 command, bool mark)
 void
 MainWin::_AdoptGlobalSettings()
 {
-	mpSettings settings = Settings::CurrentSettings();
-		// thread safe
+	mpSettings settings;
+	Settings::Default()->Get(settings);
 
 	fCloseWhenDonePlayingMovie = settings.closeWhenDonePlayingMovie;
 	fCloseWhenDonePlayingSound = settings.closeWhenDonePlayingSound;