From a574c5ce134847cdb8d40321eabfc1273c095bfc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Tue, 28 Sep 2010 11:04:07 +0000 Subject: [PATCH] For the time being, don't enable a shared BBufferGroup in overlay mode. Added TODO, since it should be fixed eventually. There seems to be a problem with mapping the BBitmap area into a BBuffer (video stays black). git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@38834 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- .../media_node_framework/video/VideoConsumer.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/apps/mediaplayer/media_node_framework/video/VideoConsumer.cpp b/src/apps/mediaplayer/media_node_framework/video/VideoConsumer.cpp index 7a87532983..9a7fd8ae97 100644 --- a/src/apps/mediaplayer/media_node_framework/video/VideoConsumer.cpp +++ b/src/apps/mediaplayer/media_node_framework/video/VideoConsumer.cpp @@ -321,10 +321,15 @@ VideoConsumer::Connected(const media_source& producer, int32 changeTag = 1; status_t ret = CreateBuffers(format); if (ret == B_OK) { - ret = SetOutputBuffersFor(producer, fIn.destination, - fBuffers, &userData, &changeTag, true); - if (ret != B_OK) - printf("SetOutputBuffersFor() failed: %s\n", strerror(ret)); + // TODO: With overlay bitmaps, there seems to be a problem with + // mapping the BBitmap areas into the BBuffers. Until that is fixed, + // don't enable a shared BBufferGroup. + if (!fTryOverlay) { + ret = SetOutputBuffersFor(producer, fIn.destination, + fBuffers, &userData, &changeTag, true); + if (ret != B_OK) + ERROR("SetOutputBuffersFor() failed: %s\n", strerror(ret)); + } fIn.format.u.raw_video.display.bytes_per_row = fBitmap[0]->BytesPerRow(); } else {