* BControl::SetValue() now calls Invalidate() again - not doing so would

break compatibility a bit too much (as this is a public class).
* Instead, we're now using the same mechanism as in Dano/Zeta, that is,
  we use BControl::SetValueNoUpdate() in the inherited classes.
* Minor cleanup.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@16183 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/kits/interface/Button.cpp

@@ -581,10 +581,8 @@ BButton::DetachedFromWindow()
 void
 BButton::SetValue(int32 value)
 {
-	if (value != Value()) {
+	if (value != Value())
 		BControl::SetValue(value);
-		Invalidate();
-	}
 }
 
 

src/kits/interface/CheckBox.cpp

@@ -1,28 +1,14 @@
-//------------------------------------------------------------------------------
+/*
-//	Copyright (c) 2001-2002, OpenBeOS
+ * Copyright 2001-2006, Haiku Inc.
-//
+ * Distributed under the terms of the MIT License.
-//	Permission is hereby granted, free of charge, to any person obtaining a
+ *
-//	copy of this software and associated documentation files (the "Software"),
+ * Authors:
-//	to deal in the Software without restriction, including without limitation
+ *		Marc Flerackers ([email protected])
-//	the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ */
-//	and/or sell copies of the Software, and to permit persons to whom the
+
-//	Software is furnished to do so, subject to the following conditions:
+/*!	BCheckBox displays an on/off control. */
-//
+
-//	The above copyright notice and this permission notice shall be included in
+
-//	all copies or substantial portions of the Software.
-//
-//	THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-//	IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-//	FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-//	AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-//	LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-//	FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
-//	DEALINGS IN THE SOFTWARE.
-//
-//	File Name:		CheckBox.cpp
-//	Author:			Marc Flerackers ([email protected])
-//	Description:	BCheckBox displays an on/off control.
-//------------------------------------------------------------------------------
 #include <CheckBox.h>
 #include <Window.h>
 
@@ -43,7 +29,6 @@ BCheckBox::BCheckBox(BRect frame, const char *name, const char *label,
 
 BCheckBox::~BCheckBox()
 {
-
 }
 
 
@@ -350,7 +335,7 @@ void
 BCheckBox::SetValue(int32 value)
 {
 	if (value != Value()) {
-		BControl::SetValue(value);
+		BControl::SetValueNoUpdate(value);
 		Invalidate(_CheckBoxFrame());
 	}
 }

src/kits/interface/ColorControl.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright 2001-2005, Haiku Inc.
+ * Copyright 2001-2006, Haiku Inc.
  * Distributed under the terms of the MIT License.
  *
  * Authors:
@@ -229,7 +229,7 @@ BColorControl::SetValue(int32 value)
 		fBlueText->SetText(string);
 	}
 
-	BControl::SetValue(value);
+	BControl::SetValueNoUpdate(value);
 
 	// TODO: This causes lot of flickering
 	Invalidate();

src/kits/interface/Control.cpp

@@ -1,37 +1,20 @@
-//------------------------------------------------------------------------------
+/*
-//	Copyright (c) 2001-2005, Haiku
+ * Copyright 2001-2006, Haiku Inc.
-//
+ * Distributed under the terms of the MIT License.
-//	Permission is hereby granted, free of charge, to any person obtaining a
+ *
-//	copy of this software and associated documentation files (the "Software"),
+ * Authors:
-//	to deal in the Software without restriction, including without limitation
+ *		Marc Flerackers (mflerackers@androme.be)
-//	the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ */
-//	and/or sell copies of the Software, and to permit persons to whom the
+
-//	Software is furnished to do so, subject to the following conditions:
+/*!	BControl is the base class for user-event handling objects. */
-//
+
-//	The above copyright notice and this permission notice shall be included in
-//	all copies or substantial portions of the Software.
-//
-//	THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-//	IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-//	FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-//	AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-//	LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
-//	FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
-//	DEALINGS IN THE SOFTWARE.
-//
-//	File Name:		Control.cpp
-//	Author:			Marc Flerackers ([email protected])
-//	Description:	BControl is the base class for user-event handling objects.
-//------------------------------------------------------------------------------
 
 #include <Control.h>
 #include <PropertyInfo.h>
 #include <Window.h>
-#include <Errors.h>
-#include <Debug.h>
 
-#include <string.h>
 #include <stdlib.h>
+#include <string.h>
 
 
 static property_info sPropertyList[] = {
@@ -308,6 +291,14 @@ BControl::Label() const
 
 void
 BControl::SetValue(int32 value)
+{
+	fValue = value;
+	Invalidate();
+}
+
+
+void
+BControl::SetValueNoUpdate(int32 value)
 {
 	fValue = value;
 }
@@ -465,13 +456,6 @@ BControl::SetTracking(bool state)
 }
 
 
-void
-BControl::SetValueNoUpdate(int32 value)
-{
-	fValue = value;
-}
-
-
 void BControl::_ReservedControl1() {}
 void BControl::_ReservedControl2() {}
 void BControl::_ReservedControl3() {}

src/kits/interface/RadioButton.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright 2001-2005, Haiku, Inc.
+ * Copyright 2001-2006, Haiku, Inc.
  * Distributed under the terms of the MIT license.
  *
  * Authors:
@@ -265,7 +265,7 @@ void
 BRadioButton::SetValue(int32 value)
 {
 	if (value != Value()) {
-		BControl::SetValue(value);
+		BControl::SetValueNoUpdate(value);
 		Invalidate(_KnobFrame());
 	}
 

src/kits/interface/Slider.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright 2001-2005, Haiku.
+ * Copyright 2001-2006, Haiku.
  * Distributed under the terms of the MIT License.
  *
  * Authors:
@@ -621,8 +621,7 @@ BSlider::SetValue(int32 value)
 
 		_SetLocation(loc);
 
-		BControl::SetValue(value);
+		BControl::SetValueNoUpdate(value);
-
 		Invalidate(oldThumbFrame | ThumbFrame());
 	}
 }