From a7ef196cf1ed5ee149c3cfbc4cce893ff3122fd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Axel=20D=C3=B6rfler?= Date: Fri, 10 Jul 2015 17:08:22 +0200 Subject: [PATCH] launch_daemon: Improved error reporting, minor cleanup. --- src/servers/launch/BaseJob.cpp | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/servers/launch/BaseJob.cpp b/src/servers/launch/BaseJob.cpp index a98ba07e46..61ed7a6c9d 100644 --- a/src/servers/launch/BaseJob.cpp +++ b/src/servers/launch/BaseJob.cpp @@ -6,7 +6,9 @@ #include "BaseJob.h" +#include #include +#include #include #include @@ -103,10 +105,10 @@ BaseJob::SetEnvironment(const BMessage& message) for (int32 index = 0; message.GetInfo(B_STRING_TYPE, index, &name, &type, &count) == B_OK; index++) { if (strcmp(name, "from_script") == 0) { - const char* fromFile; - for (int32 fileIndex = 0; message.FindString(name, fileIndex, - &fromFile) == B_OK; fileIndex++) { - fSourceFiles.Add(fromFile); + const char* fromScript; + for (int32 scriptIndex = 0; message.FindString(name, scriptIndex, + &fromScript) == B_OK; scriptIndex++) { + fSourceFiles.Add(fromScript); } continue; } @@ -166,6 +168,7 @@ BaseJob::_GetSourceFileEnvironment(const char* script, BStringList& environment) pid_t child = fork(); if (child < 0) { // TODO: log error + debug_printf("could not fork: %s\n", strerror(errno)); } else if (child == 0) { // We're the child, redirect stdout close(STDOUT_FILENO);