* Removed -Wno-unused from all KernelMergeObjects in kernel Jamfiles.

* Fixed most of the warnings resulting from that by removing actually not used
  variables or moving declaration into the #IF. Left unused functions there
  though, as I wouldn't know if they are supposed to be used again.
* Fixed two statements with no effect (clamping to MAX_ANCILLARY_DATA_LEN in
  socket.cpp and unsetting fCounterSem in MessagingService.cpp).
* Some style cleanups.

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@26253 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/system/kernel/arch/x86/Jamfile

@@ -38,7 +38,7 @@ KernelMergeObject kernel_arch_x86.o :
 
 	generic_vm_physical_page_mapper.cpp
 	:
-	$(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	$(TARGET_KERNEL_PIC_CCFLAGS)
 ;
 
 CreateAsmStructOffsetsHeader asm_offsets.h : asm_offsets.cpp ;

src/system/kernel/arch/x86/arch_cpu.c

@@ -159,8 +159,6 @@ x86_count_mtrrs(void)
 void
 x86_set_mtrr(uint32 index, uint64 base, uint64 length, uint8 type)
 {
-	cpu_status state;
-
 	struct set_mtrr_parameter parameter;
 	parameter.index = index;
 	parameter.base = base;
@@ -333,7 +331,6 @@ static int
 detect_cpu(int curr_cpu) 
 {
 	cpuid_info cpuid;
-	unsigned int data[4];
 	char vendor_str[17];
 	int i;
 	cpu_ent *cpu = get_cpu_struct();

src/system/kernel/arch/x86/arch_debug.cpp

@@ -270,7 +270,7 @@ stack_trace(int argc, char **argv)
 	struct thread *thread = NULL;
 	addr_t oldPageDirectory = 0;
 	uint32 ebp = x86_read_ebp();
-	int32 i, num = 0, last = 0;
+	int32 num = 0, last = 0;
 
 	setup_for_thread(argc == 2 ? argv[1] : NULL, &thread, &ebp,
 		&oldPageDirectory);
@@ -490,7 +490,6 @@ dump_iframes(int argc, char **argv)
 	}
 
 	struct thread *thread = NULL;
-	int32 i;
 
 	if (argc < 2) {
 		thread = thread_get_current_thread();

src/system/kernel/arch/x86/arch_debug_console.c

@@ -186,7 +186,7 @@ arch_debug_blue_screen_getchar(void)
 	static bool altPressed = false;
 	static uint8 special = 0;
 	static uint8 special2 = 0;
-	uint8 key, ascii = 0;
+	uint8 key = 0;
 
 	if (special & 0x80) {
 		special &= ~0x80;

src/system/kernel/arch/x86/arch_thread.cpp

@@ -310,7 +310,6 @@ status_t
 arch_thread_init_tls(struct thread *thread)
 {
 	uint32 tls[TLS_USER_THREAD_SLOT + 1];
-	int32 i;
 
 	thread->user_local_storage = thread->user_stack_base
 		+ thread->user_stack_size;

src/system/kernel/arch/x86/arch_user_debugger.cpp

@@ -530,8 +530,6 @@ void
 arch_set_debug_cpu_state(const struct debug_cpu_state *cpuState)
 {
 	if (struct iframe *frame = i386_get_user_iframe()) {
-		struct thread *thread = thread_get_current_thread();
-
 		i386_frstor(cpuState->extended_regs);
 			// For this to be correct the calling function must not use these
 			// registers (not even indirectly).
@@ -564,8 +562,6 @@ void
 arch_get_debug_cpu_state(struct debug_cpu_state *cpuState)
 {
 	if (struct iframe *frame = i386_get_user_iframe()) {
-		struct thread *thread = thread_get_current_thread();
-
 		i386_fnsave(cpuState->extended_regs);
 			// For this to be correct the calling function must not use these
 			// registers (not even indirectly).

src/system/kernel/cache/Jamfile

@@ -6,5 +6,5 @@ KernelMergeObject kernel_cache.o :
 	file_map.cpp
 	vnode_store.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/debug/Jamfile

@@ -17,5 +17,5 @@ KernelMergeObject kernel_debug.o :
 	tracing.cpp
 	user_debugger.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/debug/debug.cpp

@@ -87,7 +87,6 @@ static const uint32 kMaxDebuggerModules = sizeof(sDebuggerModules)
 #define HISTORY_SIZE 16
 
 static char sLineBuffer[HISTORY_SIZE][LINE_BUFFER_SIZE] = { "", };
-static char sParseLine[LINE_BUFFER_SIZE];
 static int32 sCurrentLine = 0;
 
 #define distance(a, b) ((a) < (b) ? (b) - (a) : (a) - (b))
@@ -880,8 +879,6 @@ syslog_init(struct kernel_args *args)
 	syslog_write(revisionBuffer, length);
 	return B_OK;
 
-err3:
-	free(sSyslogBuffer);
 err2:
 	free(sSyslogMessage);
 err1:

src/system/kernel/debug/debug_commands.cpp

@@ -392,7 +392,6 @@ sort_debugger_commands()
 			}
 
 			if (strcmp((*command)->name, nextCommand->name) > 0) {
-				debugger_command* tmpCommand = nextCommand->next;
 				(*command)->next = nextCommand->next;
 				nextCommand->next = *command;
 				*command = nextCommand;

src/system/kernel/debug/debug_variables.cpp

@@ -109,9 +109,6 @@ free_temporary_variable_slot()
 static Variable*
 get_variable(const char* variableName, bool create)
 {
-	Variable* variables;
-	int variableCount;
-
 	// find the variable in the respective array and a free slot, we can
 	// use, if it doesn't exist yet
 	Variable* freeSlot = NULL;

src/system/kernel/debug/user_debugger.cpp

@@ -2214,7 +2214,6 @@ void
 _user_debugger(const char *userMessage)
 {
 	// install the default debugger, if there is none yet
-	struct thread *thread = thread_get_current_thread();
 	port_id nubPort;
 	status_t error = ensure_debugger_installed(B_CURRENT_TEAM, &nubPort);
 	if (error != B_OK) {

src/system/kernel/device_manager/Jamfile

@@ -13,5 +13,5 @@ KernelMergeObject kernel_device_manager.o :
 #	probe.cpp
 	settings.cpp
 	:
-	$(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	$(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/device_manager/devfs.cpp

@@ -1190,7 +1190,6 @@ devfs_read_link(fs_volume *_volume, fs_vnode *_link, char *buffer,
 	size_t *_bufferSize)
 {
 	struct devfs_vnode *link = (struct devfs_vnode *)_link->private_node;
-	size_t bufferSize = *_bufferSize;
 
 	if (!S_ISLNK(link->stream.type))
 		return B_BAD_VALUE;
@@ -1461,7 +1460,6 @@ static status_t
 devfs_ioctl(fs_volume *_volume, fs_vnode *_vnode, void *_cookie, ulong op,
 	void *buffer, size_t length)
 {
-	struct devfs *fs = (struct devfs *)_volume->private_volume;
 	struct devfs_vnode *vnode = (struct devfs_vnode *)_vnode->private_node;
 	struct devfs_cookie *cookie = (struct devfs_cookie *)_cookie;
 
@@ -1499,8 +1497,8 @@ devfs_ioctl(fs_volume *_volume, fs_vnode *_vnode, void *_cookie, ulong op,
 
 			case B_GET_DRIVER_FOR_DEVICE:
 			{
-				const char* path;
 #if 0
+				const char* path;
 				if (!vnode->stream.u.dev.driver)
 					return B_ENTRY_NOT_FOUND;
 				path = vnode->stream.u.dev.driver->path;
@@ -1531,7 +1529,6 @@ devfs_ioctl(fs_volume *_volume, fs_vnode *_vnode, void *_cookie, ulong op,
 			case B_GET_PATH_FOR_DEVICE:
 			{
 				char path[256];
-				status_t err;
 				/* TODO: we might want to actually find the mountpoint
 				 * of that instance of devfs...
 				 * but for now we assume it's mounted on /dev

src/system/kernel/device_manager/device_manager.cpp

@@ -194,8 +194,6 @@ static device_node *sRootNode;
 static recursive_lock sLock;
 static const char* sGenericContextPath;
 
-static uint32 sDriverUpdateCycle = 1;
-
 
 //	#pragma mark -
 

src/system/kernel/device_manager/legacy_drivers.cpp

@@ -178,7 +178,6 @@ static status_t unload_driver(legacy_driver *driver);
 static status_t load_driver(legacy_driver *driver);
 
 
-static int32 sDefaultApiVersion = 1;
 static hash_table* sDriverHash;
 static DriverWatcher sDriverWatcher;
 static int32 sDriverEvents;
@@ -334,8 +333,6 @@ load_driver(legacy_driver *driver)
 {
 	status_t (*init_hardware)(void);
 	status_t (*init_driver)(void);
-	const char **devicePaths;
-	int32 exported = 0;
 	status_t status;
 
 	driver->binary_updated = false;
@@ -417,10 +414,6 @@ load_driver(legacy_driver *driver)
 	driver->image = image;
 	return republish_driver(driver);
 
-error3:
-	if (driver->uninit_driver)
-		driver->uninit_driver();
-
 error2:
 	if (driver->uninit_hardware)
 		driver->uninit_hardware();
@@ -679,10 +672,8 @@ reload_driver(legacy_driver *driver)
 
 
 static void
-handle_driver_events(void *_fs, int /*iteration*/)
+handle_driver_events(void */*_fs*/, int /*iteration*/)
 {
-	struct devfs *fs = (devfs *)_fs;
-
 	if (atomic_and(&sDriverEvents, 0) == 0)
 		return;
 

src/system/kernel/disk_device_manager/Jamfile

@@ -33,7 +33,7 @@ KernelMergeObject kernel_disk_device_manager.o :
 	# disk device types
 	DiskDeviceTypes.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;
 
 # KFileDiskDevice.cpp needs the virtualdrive.h Header. Add it here to not

src/system/kernel/fs/Jamfile

@@ -17,5 +17,5 @@ KernelMergeObject kernel_fs.o :
 	vfs_boot.cpp
 	vfs_net_boot.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/fs/fd.cpp

@@ -856,8 +856,6 @@ _user_seek(int fd, off_t pos, int seekType)
 status_t
 _user_ioctl(int fd, ulong op, void *buffer, size_t length)
 {
-	struct file_descriptor *descriptor;
-
 	if (!IS_USER_ADDRESS(buffer))
 		return B_BAD_ADDRESS;
 

src/system/kernel/fs/socket.cpp

@@ -946,7 +946,7 @@ _user_recvmsg(int socket, struct msghdr *userMessage, int flags)
 		if (message.msg_controllen < 0)
 			return B_BAD_VALUE;
 		if (message.msg_controllen > MAX_ANCILLARY_DATA_LEN)
-			message.msg_controllen > MAX_ANCILLARY_DATA_LEN;
+			message.msg_controllen = MAX_ANCILLARY_DATA_LEN;
 
 		message.msg_control = ancillary = malloc(message.msg_controllen);
 		if (message.msg_control == NULL)

src/system/kernel/fs/vfs.cpp

@@ -169,8 +169,6 @@ struct advisory_locking {
 	}
 };
 
-static mutex sFileSystemsMutex = MUTEX_INITIALIZER("vfs_lock");
-
 /*!	\brief Guards sMountsTable.
 
 	The holder is allowed to read/write access the sMountsTable.
@@ -539,7 +537,6 @@ static status_t
 get_mount(dev_t id, struct fs_mount **_mount)
 {
 	struct fs_mount *mount;
-	status_t status;
 
 	MutexLocker nodeLocker(sVnodeMutex);
 	MutexLocker mountLocker(sMountMutex);
@@ -1042,8 +1039,6 @@ vnode_low_memory_handler(void */*data*/, int32 level)
 
 	// Write back the modified pages of some unused vnodes and free them
 
-	uint32 freeCount = count;
-
 	for (uint32 i = 0; i < count; i++) {
 		mutex_lock(&sVnodeMutex);
 		struct vnode *vnode = (struct vnode *)list_remove_head_item(
@@ -1846,7 +1841,6 @@ vnode_path_to_vnode(struct vnode *vnode, char *path, bool traverseLeafLink,
 
 	while (true) {
 		struct vnode *nextVnode;
-		ino_t vnodeID;
 		char *nextPath;
 
 		TRACE(("vnode_path_to_vnode: top of loop. p = %p, p = '%s'\n", path, path));
@@ -4215,8 +4209,6 @@ vfs_free_io_context(void *_ioContext)
 static status_t
 vfs_resize_fd_table(struct io_context *context, const int newSize)
 {
-	struct file_descriptor **fds;
-
 	if (newSize <= 0 || newSize > MAX_FD_TABLE_SIZE)
 		return EINVAL;
 
@@ -4278,7 +4270,6 @@ vfs_resize_fd_table(struct io_context *context, const int newSize)
 static status_t
 vfs_resize_monitor_table(struct io_context *context, const int newSize)
 {
-	void *fds;
 	int	status = B_OK;
 
 	if (newSize <= 0 || newSize > MAX_NODE_MONITORS)
@@ -7208,8 +7199,6 @@ _kern_remove_dir(int fd, const char *path)
 status_t
 _kern_read_link(int fd, const char *path, char *buffer, size_t *_bufferSize)
 {
-	status_t status;
-
 	if (path) {
 		KPath pathBuffer(path, false, B_PATH_NAME_LENGTH + 1);
 		if (pathBuffer.InitCheck() != B_OK)
@@ -7837,7 +7826,6 @@ _user_normalize_path(const char* userPath, bool traverseLink, char* buffer)
 		}
 
 		// read link
-		struct stat st;
 		if (HAS_FS_CALL(fileVnode, read_symlink)) {
 			size_t bufferSize = B_PATH_NAME_LENGTH - 1;
 			error = FS_CALL(fileVnode, read_symlink, path, &bufferSize);

src/system/kernel/fs/vfs_net_boot.cpp

@@ -121,8 +121,6 @@ private:
 			return;
 		}
 
-		status_t error = B_OK;
-
 		while (dirent* entry = readdir(dir)) {
 			// skip "." and ".."
 			if (strcmp(entry->d_name, ".") == 0

src/system/kernel/messaging/Jamfile

@@ -12,5 +12,5 @@ KernelMergeObject kernel_messaging.o :
 	KMessage.cpp
 	MessagingService.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/messaging/MessagingService.cpp

@@ -377,7 +377,7 @@ MessagingService::UnregisterService()
 
 	// unset the other members
 	fLockSem = -1;
-	fCounterSem -1;
+	fCounterSem = -1;
 	fServerTeam = -1;
 
 	return B_OK;

src/system/kernel/posix/Jamfile

@@ -5,5 +5,5 @@ UsePrivateHeaders shared ;
 KernelMergeObject kernel_posix.o : 
 	realtime_sem.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;

src/system/kernel/slab/Jamfile

@@ -6,5 +6,5 @@ KernelMergeObject kernel_slab.o :
 	allocator.cpp
 	Slab.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 	;

src/system/kernel/util/Jamfile

@@ -11,5 +11,5 @@ KernelMergeObject kernel_util.o :
 	queue.c
 	ring_buffer.cpp
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused -DUSING_LIBGCC
+	: $(TARGET_KERNEL_PIC_CCFLAGS) -DUSING_LIBGCC
 ;

src/system/kernel/vm/Jamfile

@@ -14,5 +14,5 @@ KernelMergeObject kernel_vm.o :
 	vm_store_null.c
 	#vm_tests.c
 
-	: $(TARGET_KERNEL_PIC_CCFLAGS) -Wno-unused
+	: $(TARGET_KERNEL_PIC_CCFLAGS)
 ;