i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bfs: Fixed leaking cookie regression.

Browse Source 
* Introduced with the last commit.
This commit is contained in:
Axel Dörfler
2017-02-19 18:22:28 +01:00
parent 7abafe9f3f
commit a90df70af5
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/bfs/Attribute.cpp
+7 -6
View File
@@ -3,7 +3,8 @@
* This file may be used under the terms of the MIT License. * This file may be used under the terms of the MIT License.
*/ */
//! connection between pure inode and kernel_interface attributes
//! Connection between pure inode and kernel_interface attributes.
#include "Attribute.h" #include "Attribute.h"
@@ -120,17 +121,17 @@ Attribute::Create(const char* name, type_code type, int openMode,
attr_cookie** _cookie) attr_cookie** _cookie)
{ {
status_t status = CheckAccess(name, openMode); status_t status = CheckAccess(name, openMode);
if (status < B_OK) if (status != B_OK)
return status; return status;
attr_cookie* cookie = new(std::nothrow) attr_cookie;
if (cookie == NULL)
RETURN_ERROR(B_NO_MEMORY);
bool exists = Get(name) == B_OK; bool exists = Get(name) == B_OK;
if (exists && (openMode & O_EXCL) != 0) if (exists && (openMode & O_EXCL) != 0)
return B_FILE_EXISTS; return B_FILE_EXISTS;
attr_cookie* cookie = new(std::nothrow) attr_cookie;
if (cookie == NULL)
RETURN_ERROR(B_NO_MEMORY);
fName = name; fName = name;
// initialize the cookie // initialize the cookie