From ab56137e2411f03672cd5a65875a82ade5dd19b0 Mon Sep 17 00:00:00 2001 From: Adrien Destugues Date: Mon, 26 Aug 2019 21:32:57 +0200 Subject: [PATCH] IconCache: remove incorrect ASSERT() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code does just fine both if entry is NULL and if it doesn't have an icon. However, if entry is NULL, this assert calls a method on it, which is a bad idea. Change-Id: I80b314db373970d99eb008aeaec6254d14c39ca7 Reviewed-on: https://review.haiku-os.org/c/haiku/+/1749 Reviewed-by: Stephan Aßmus --- src/kits/tracker/IconCache.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/kits/tracker/IconCache.cpp b/src/kits/tracker/IconCache.cpp index 1812a3ea84..26d9d0bbc8 100644 --- a/src/kits/tracker/IconCache.cpp +++ b/src/kits/tracker/IconCache.cpp @@ -1007,7 +1007,6 @@ IconCache::Preload(AutoLock* nodeCacheLocker, entry = GetIconFromFileTypes(&modelOpener, source, mode, size, &lazyBitmap, 0); - ASSERT(entry != NULL || entry->HaveIconBitmap(mode, size)); if (entry == NULL || !entry->HaveIconBitmap(mode, size)) { // we don't have an icon, go with the generic