Debugger: Use readline in the CLI

This is a bit hacky, since gdb's readline is used. It would probably be
best to prepare an optional build package.

src/apps/debugger/Jamfile

@@ -6,6 +6,9 @@ C++FLAGS += -Werror ;
 UsePrivateHeaders app debug interface kernel shared libroot ;
 UsePrivateSystemHeaders ;
 
+# Use gdb's readline. It would be better to use an optional build feature.
+UseHeaders [ FDirName $(HAIKU_TOP) src bin gdb ] : true ;
+
 SEARCH_SOURCE += [ FDirName $(SUBDIR) arch ] ;
 SEARCH_SOURCE += [ FDirName $(SUBDIR) arch x86 ] ;
 SEARCH_SOURCE += [ FDirName $(SUBDIR) debug_info ] ;
@@ -273,9 +276,14 @@ Application Debugger :
 	<bin>debug_utils.a
 	libcolumnlistview.a
 	libshared.a
+	libshared.a
+	libexpression_parser.a
+	libmapm.a
+	<gdb>libreadline.a
+	libtermcap.a
 
 	$(TARGET_LIBSTDC++)
-	be tracker libdebug.so libshared.a libexpression_parser.a libmapm.a
+	be tracker libdebug.so
 
 	: Debugger.rdef
 ;

src/apps/debugger/user_interface/cli/CommandLineUserInterface.cpp

@@ -11,7 +11,11 @@
 
 #include <algorithm>
 
+#include <readline/history.h>
+#include <readline/readline.h>
+
 #include <ArgumentVector.h>
+#include <AutoDeleter.h>
 #include <Referenceable.h>
 
 #include "CliCommand.h"
@@ -226,16 +230,15 @@ CommandLineUserInterface::_InputLoop()
 {
 	while (!fTerminating) {
 		// read a command line
-		printf("debugger> ");
+		char* line = readline("debugger> ");
-		fflush(stdout);
+		if (line == NULL)
-		char buffer[256];
-		if (fgets(buffer, sizeof(buffer), stdin) == NULL)
 			break;
+		MemoryDeleter lineDeleter(line);
 
 		// parse the command line
 		ArgumentVector args;
 		const char* parseErrorLocation;
-		switch (args.Parse(buffer, &parseErrorLocation)) {
+		switch (args.Parse(line, &parseErrorLocation)) {
 			case ArgumentVector::NO_ERROR:
 				break;
 			case ArgumentVector::NO_MEMORY:
@@ -243,7 +246,7 @@ CommandLineUserInterface::_InputLoop()
 				continue;
 			case ArgumentVector::UNTERMINATED_QUOTED_STRING:
 				printf("Parse error: Unterminated quoted string starting at "
-					"character %zu.\n", parseErrorLocation - buffer + 1);
+					"character %zu.\n", parseErrorLocation - line + 1);
 				continue;
 			case ArgumentVector::TRAILING_BACKSPACE:
 				printf("Parse error: trailing backspace.\n");
@@ -253,6 +256,8 @@ CommandLineUserInterface::_InputLoop()
 		if (args.ArgumentCount() == 0)
 			continue;
 
+		add_history(line);
+
 		_ExecuteCommand(args.ArgumentCount(), args.Arguments());
 	}