i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable some more Werror and fix compiler warnings

Browse Source 
- All servers are now Werror
- All bus_managers are now Werror
- All input_server add-ons are now Werror
- Some more things in bin/ are Werror

Only tested on x86_64, I'll let the buildbot test on x86_gcc2 and RISC-V

Change-Id: I5ec86512eac729c862828a45d8431f85c4ec422b
Reviewed-on: https://review.haiku-os.org/c/haiku/+/5226
Tested-by: Commit checker robot <[email protected]>
Reviewed-by: Jérôme Duval <[email protected]>
This commit is contained in:
Adrien Destugues
2022-04-22 14:25:48 +00:00
committed by Adrien Destugues
parent adc32659fb
commit ad398477d6
7 changed files with 22 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
build/jam/ArchitectureRules
+5 -35
View File
@@ -662,24 +662,9 @@ rule ArchitectureSetupWarnings architecture
EnableWerror src add-ons bluetooth ; EnableWerror src add-ons bluetooth ;
EnableWerror src add-ons decorators ; EnableWerror src add-ons decorators ;
EnableWerror src add-ons disk_systems ; EnableWerror src add-ons disk_systems ;
EnableWerror src add-ons input_server devices ; EnableWerror src add-ons input_server ;
EnableWerror src add-ons input_server filters ;
EnableWerror src add-ons input_server methods pen ;
EnableWerror src add-ons input_server methods t9 ;
EnableWerror src add-ons kernel bluetooth ; EnableWerror src add-ons kernel bluetooth ;
EnableWerror src add-ons kernel bus_managers acpi ; EnableWerror src add-ons kernel bus_managers ;
EnableWerror src add-ons kernel bus_managers agp_gart ;
EnableWerror src add-ons kernel bus_managers ata ;
EnableWerror src add-ons kernel bus_managers firewire ;
EnableWerror src add-ons kernel bus_managers ide ;
EnableWerror src add-ons kernel bus_managers isa ;
EnableWerror src add-ons kernel bus_managers pci ;
EnableWerror src add-ons kernel bus_managers ps2 ;
EnableWerror src add-ons kernel bus_managers random ;
EnableWerror src add-ons kernel bus_managers scsi ;
EnableWerror src add-ons kernel bus_managers tty ;
EnableWerror src add-ons kernel bus_managers usb ;
EnableWerror src add-ons kernel bus_managers virtio ;
EnableWerror src add-ons kernel busses agp_gart ; EnableWerror src add-ons kernel busses agp_gart ;
EnableWerror src add-ons kernel busses ata ; EnableWerror src add-ons kernel busses ata ;
# EnableWerror src add-ons kernel busses i2c ; # EnableWerror src add-ons kernel busses i2c ;
@@ -732,24 +717,7 @@ rule ArchitectureSetupWarnings architecture
EnableWerror src add-ons kernel power ; EnableWerror src add-ons kernel power ;
EnableWerror src add-ons locale ; EnableWerror src add-ons locale ;
EnableWerror src add-ons mail_daemon ; EnableWerror src add-ons mail_daemon ;
EnableWerror src add-ons media media-add-ons demultiplexer ; EnableWerror src add-ons media media-add-ons ;
EnableWerror src add-ons media media-add-ons dvb ;
EnableWerror src add-ons media media-add-ons esound_sink ;
EnableWerror src add-ons media media-add-ons finepix_webcam ;
EnableWerror src add-ons media media-add-ons firewire_dv ;
EnableWerror src add-ons media media-add-ons legacy ;
EnableWerror src add-ons media media-add-ons mixer ;
EnableWerror src add-ons media media-add-ons multi_audio ;
EnableWerror src add-ons media media-add-ons opensound ;
EnableWerror src add-ons media media-add-ons radeon ;
EnableWerror src add-ons media media-add-ons reader ;
EnableWerror src add-ons media media-add-ons tone_producer_demo ;
EnableWerror src add-ons media media-add-ons usb_vision ;
EnableWerror src add-ons media media-add-ons usb_webcam ;
EnableWerror src add-ons media media-add-ons video_mixer ;
EnableWerror src add-ons media media-add-ons video_producer_demo ;
EnableWerror src add-ons media media-add-ons videowindow ;
EnableWerror src add-ons media media-add-ons writer ;
EnableWerror src add-ons media plugins ape_reader ; EnableWerror src add-ons media plugins ape_reader ;
EnableWerror src add-ons media plugins au_reader ; EnableWerror src add-ons media plugins au_reader ;
# EnableWerror src add-ons media plugins ffmpeg ; # EnableWerror src add-ons media plugins ffmpeg ;
@@ -777,10 +745,12 @@ rule ArchitectureSetupWarnings architecture
EnableWerror src add-ons translators wonderbrush ; EnableWerror src add-ons translators wonderbrush ;
EnableWerror src add-ons print ; EnableWerror src add-ons print ;
EnableWerror src bin desklink ; EnableWerror src bin desklink ;
EnableWerror src bin listusb ;
EnableWerror src bin multiuser ; EnableWerror src bin multiuser ;
EnableWerror src bin package ; EnableWerror src bin package ;
EnableWerror src bin package_repo ; EnableWerror src bin package_repo ;
EnableWerror src bin pkgman ; EnableWerror src bin pkgman ;
EnableWerror src bin writembr ;
EnableWerror src libs bsd ; EnableWerror src libs bsd ;
EnableWerror src apps ; EnableWerror src apps ;
EnableWerror src kits ; EnableWerror src kits ;
headers/os/media/TimedEventQueue.h
+1 -1
View File
@@ -21,7 +21,7 @@ struct media_timed_event {
bigtime_t inTime, int32 inType, bigtime_t inTime, int32 inType,
void* inPointer, uint32 inCleanup, void* inPointer, uint32 inCleanup,
int32 inData, int64 inBigdata, int32 inData, int64 inBigdata,
char* inUserData, size_t dataSize = 0); const char* inUserData, size_t dataSize = 0);
media_timed_event( media_timed_event(
const media_timed_event& other); const media_timed_event& other);
headers/private/drivers/mmc.h
+2 -2
View File
@@ -110,8 +110,8 @@ typedef struct mmc_device_interface {
// Device attribute paths for the MMC device // Device attribute paths for the MMC device
static const char* kMmcRcaAttribute = "mmc/rca"; const char* const kMmcRcaAttribute = "mmc/rca";
static const char* kMmcTypeAttribute = "mmc/type"; const char* const kMmcTypeAttribute = "mmc/type";
#endif /* _MMC_H */ #endif /* _MMC_H */
src/add-ons/media/media-add-ons/mixer/Interpolate.cpp
+6 -6
View File
@@ -25,10 +25,10 @@ kernel(Resampler* object, const void *_src, int32 srcSampleOffset,
int32 srcSampleCount, void *_dest, int32 destSampleOffset, int32 srcSampleCount, void *_dest, int32 destSampleOffset,
int32 destSampleCount, float _gain) int32 destSampleCount, float _gain)
{ {
register const char * src = (const char *)_src; const char * src = (const char *)_src;
register char * dest = (char *)_dest; char * dest = (char *)_dest;
register int32 count = destSampleCount; int32 count = destSampleCount;
register float gain = _gain * gnum / gden; float gain = _gain * gnum / gden;
if (srcSampleCount == destSampleCount) { if (srcSampleCount == destSampleCount) {
// optimized case for no resampling // optimized case for no resampling
@@ -46,8 +46,8 @@ kernel(Resampler* object, const void *_src, int32 srcSampleOffset,
return; return;
} }
register float delta = float(srcSampleCount) / float(destSampleCount); float delta = float(srcSampleCount) / float(destSampleCount);
register float current = 0.0f; float current = 0.0f;
float oldSample = ((Interpolate*)object)->fOldSample; float oldSample = ((Interpolate*)object)->fOldSample;
#define SRC *(const inType*)(src) #define SRC *(const inType*)(src)
src/bin/listusb/listusb.cpp
+6 -6
View File
@@ -209,11 +209,11 @@ DumpCDCDescriptor(const usb_generic_descriptor* descriptor, int subclass)
= (const usb_cdc_cm_functional_descriptor*)descriptor; = (const usb_cdc_cm_functional_descriptor*)descriptor;
printf(" Capabilities ..... "); printf(" Capabilities ..... ");
bool somethingPrinted = false; bool somethingPrinted = false;
if (cmDesc->capabilities & USB_CDC_CM_DOES_CALL_MANAGEMENT != 0) { if ((cmDesc->capabilities & USB_CDC_CM_DOES_CALL_MANAGEMENT) != 0) {
printf("Call management"); printf("Call management");
somethingPrinted = true; somethingPrinted = true;
} }
if (cmDesc->capabilities & USB_CDC_CM_OVER_DATA_INTERFACE != 0) { if ((cmDesc->capabilities & USB_CDC_CM_OVER_DATA_INTERFACE) != 0) {
if (somethingPrinted) if (somethingPrinted)
printf(", "); printf(", ");
printf("Over data interface"); printf("Over data interface");
@@ -232,23 +232,23 @@ DumpCDCDescriptor(const usb_generic_descriptor* descriptor, int subclass)
= (const usb_cdc_acm_functional_descriptor*)descriptor; = (const usb_cdc_acm_functional_descriptor*)descriptor;
printf(" Capabilities ..... "); printf(" Capabilities ..... ");
bool somethingPrinted = false; bool somethingPrinted = false;
if (acmDesc->capabilities & USB_CDC_ACM_HAS_COMM_FEATURES != 0) { if ((acmDesc->capabilities & USB_CDC_ACM_HAS_COMM_FEATURES) != 0) {
printf("Communication features"); printf("Communication features");
somethingPrinted = true; somethingPrinted = true;
} }
if (acmDesc->capabilities & USB_CDC_ACM_HAS_LINE_CONTROL != 0) { if ((acmDesc->capabilities & USB_CDC_ACM_HAS_LINE_CONTROL) != 0) {
if (somethingPrinted) if (somethingPrinted)
printf(", "); printf(", ");
printf("Line control"); printf("Line control");
somethingPrinted = true; somethingPrinted = true;
} }
if (acmDesc->capabilities & USB_CDC_ACM_HAS_SEND_BREAK != 0) { if ((acmDesc->capabilities & USB_CDC_ACM_HAS_SEND_BREAK) != 0) {
if (somethingPrinted) if (somethingPrinted)
printf(", "); printf(", ");
printf("Send break"); printf("Send break");
somethingPrinted = true; somethingPrinted = true;
} }
if (acmDesc->capabilities & USB_CDC_ACM_HAS_NETWORK_CONNECTION != 0) { if ((acmDesc->capabilities & USB_CDC_ACM_HAS_NETWORK_CONNECTION) != 0) {
if (somethingPrinted) if (somethingPrinted)
printf(", "); printf(", ");
printf("Network connection"); printf("Network connection");
src/bin/writembr/writembr.cpp
+1 -1
View File
@@ -78,7 +78,7 @@ main(int argc, char** argv)
unsigned char MBR[kMBRSize]; unsigned char MBR[kMBRSize];
fs.read((char*)MBR, kMBRSize); fs.read((char*)MBR, kMBRSize);
if (fs.fail() || fs.gcount() < kMBRSize ) { if (fs.fail() || fs.gcount() < (off_t)kMBRSize ) {
cerr << "Cannot read " << kMBRSize cerr << "Cannot read " << kMBRSize
<< " bytes from " << device.Path() << endl; << " bytes from " << device.Path() << endl;
fs.close(); fs.close();
src/kits/media/TimedEventQueue.cpp
+1 -1
View File
@@ -50,7 +50,7 @@ media_timed_event::media_timed_event(bigtime_t inTime,
uint32 inCleanup, uint32 inCleanup,
int32 inData, int32 inData,
int64 inBigdata, int64 inBigdata,
char *inUserData, const char *inUserData,
size_t dataSize) size_t dataSize)
{ {
CALLED(); CALLED();