From ae3724532e7e498d0ac591023d58447afedb2240 Mon Sep 17 00:00:00 2001 From: Freaxed Date: Thu, 22 Jun 2023 11:19:05 +0200 Subject: [PATCH] AboutWindow: fixed invalid string pointer on application version Change-Id: I6caf78fffddedca322464dcb4350ba03bb0b0207 Reviewed-on: https://review.haiku-os.org/c/haiku/+/6637 Tested-by: Commit checker robot Reviewed-by: Adrien Destugues --- src/kits/interface/AboutWindow.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/kits/interface/AboutWindow.cpp b/src/kits/interface/AboutWindow.cpp index 17bcd31617..0b03104403 100644 --- a/src/kits/interface/AboutWindow.cpp +++ b/src/kits/interface/AboutWindow.cpp @@ -85,7 +85,7 @@ public: status_t SetVersion(const char* version); private: - const char* _GetVersionFromSignature(const char* signature); + BString _GetVersionFromSignature(const char* signature); BBitmap* _GetIconFromSignature(const char* signature); private: @@ -175,7 +175,7 @@ AboutView::AboutView(const char* appName, const char* signature) fNameView->SetExplicitMaxSize(BSize(B_SIZE_UNLIMITED, B_SIZE_UNSET)); fVersionView = new BStringView("version", - _GetVersionFromSignature(signature)); + _GetVersionFromSignature(signature).String()); fVersionView->SetExplicitMaxSize(BSize(B_SIZE_UNLIMITED, B_SIZE_UNSET)); rgb_color documentColor = ui_color(B_DOCUMENT_TEXT_COLOR); @@ -235,7 +235,7 @@ AboutView::AllAttached() // #pragma mark - AboutView private methods -const char* +BString AboutView::_GetVersionFromSignature(const char* signature) { if (signature == NULL) @@ -289,7 +289,7 @@ AboutView::_GetVersionFromSignature(const char* signature) appVersion << "-" << variety; } - return appVersion.String(); + return appVersion; } return NULL;