From af0c1fa6589a22b62e8469ab9a2cc353f6816e5a Mon Sep 17 00:00:00 2001 From: Greg Crain Date: Wed, 29 Nov 2017 08:22:08 -0500 Subject: [PATCH] xhci: fix hub descriptor command request MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The command to get the hub descriptor needs to be a class request and was incorrect causing a Stall error for the hub. The the driver does not handle a stall error yet, causing odd behavior. Signed-off-by: Jérôme Duval --- src/add-ons/kernel/busses/usb/xhci.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/add-ons/kernel/busses/usb/xhci.cpp b/src/add-ons/kernel/busses/usb/xhci.cpp index 5613f943b6..089cfaf1ee 100644 --- a/src/add-ons/kernel/busses/usb/xhci.cpp +++ b/src/add-ons/kernel/busses/usb/xhci.cpp @@ -1349,7 +1349,7 @@ XHCI::AllocateDevice(Hub *parent, int8 hubAddress, uint8 hubPort, size_t actualLength = 0; usb_hub_descriptor hubDescriptor; pipe.SendRequest( - USB_REQTYPE_DEVICE_IN | USB_REQTYPE_STANDARD, // type + USB_REQTYPE_DEVICE_IN | USB_REQTYPE_CLASS, // type USB_REQUEST_GET_DESCRIPTOR, // request USB_DESCRIPTOR_HUB << 8, // value 0, // index