From b0eaa06c2673fb040394746fdcad4312f0496a60 Mon Sep 17 00:00:00 2001 From: Ingo Weinhold Date: Fri, 2 Jul 2010 23:29:59 +0000 Subject: [PATCH] Disable re-attaching the tracing buffer of a previous session. It still has some problems. git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@37359 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/system/kernel/debug/tracing.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/system/kernel/debug/tracing.cpp b/src/system/kernel/debug/tracing.cpp index c48d0a0253..868341a01a 100644 --- a/src/system/kernel/debug/tracing.cpp +++ b/src/system/kernel/debug/tracing.cpp @@ -454,6 +454,14 @@ TracingMetaData::_CreateMetaDataArea(bool findPrevious, area_id& _area, bool TracingMetaData::_InitPreviousTracingData() { + // TODO: ATM re-attaching the previous tracing buffer doesn't work very + // well. The entries should checked more thoroughly for validity -- e.g. the + // pointers to the entries' vtable pointers could be invalid, which can + // make the "traced" command quite unusable. The validity of the entries + // could be checked in a safe environment (i.e. with a fault handler) with + // typeid() and call of a virtual function. + return false; + addr_t bufferStart = (addr_t)fTraceOutputBuffer + kTraceOutputBufferSize; addr_t bufferEnd = bufferStart + MAX_TRACE_SIZE;