i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Writing in PIO mode was broken; thanks to Thomas for looking into it.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/trunk/current@9969 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Axel Dörfler
2004-11-15 23:16:28 +00:00
parent f16f960989
commit b28f1889df
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/bus_managers/ide/ata.c
+3 -4
View File
@@ -55,7 +55,7 @@ ata_dpc_PIO(ide_qrequest *qrequest)
SHOW_FLOW0(3, ""); SHOW_FLOW0(3, "");
if (check_rw_error(device, qrequest) if (check_rw_error(device, qrequest)
|| !check_rw_status(device, qrequest->is_write ? device->left_blocks > 1 : true)) || !check_rw_status(device, qrequest->is_write ? device->left_blocks > 0 : true))
{ {
// failure reported by device // failure reported by device
SHOW_FLOW0( 3, "command finished unsuccessfully" ); SHOW_FLOW0( 3, "command finished unsuccessfully" );
@@ -68,7 +68,7 @@ ata_dpc_PIO(ide_qrequest *qrequest)
if (device->left_blocks == 0) { if (device->left_blocks == 0) {
// this was the end-of-transmission IRQ // this was the end-of-transmission IRQ
SHOW_FLOW0(3, "write access finished"); SHOW_FLOW0(3, "write access finished");
if (!wait_for_drq(device)) { if (!wait_for_drqdown(device)) {
SHOW_ERROR0(3, "device wants to transmit data though command is finished"); SHOW_ERROR0(3, "device wants to transmit data though command is finished");
goto finish; goto finish;
} }
@@ -88,8 +88,7 @@ ata_dpc_PIO(ide_qrequest *qrequest)
// so we better start waiting too early; as we are in service thread, // so we better start waiting too early; as we are in service thread,
// a DPC initiated by IRQ cannot overtake us, so there is no need to block // a DPC initiated by IRQ cannot overtake us, so there is no need to block
// IRQs during sent // IRQs during sent
if (device->left_blocks > 1) start_waiting_nolock(device->bus, timeout, ide_state_async_waiting);
start_waiting_nolock(device->bus, timeout, ide_state_async_waiting);
// having a too short data buffer shouldn't happen here // having a too short data buffer shouldn't happen here
// anyway - we are prepared // anyway - we are prepared