i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Send notifications for directwindow when a window is moved

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@14843 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stefano Ceccherini
2005-11-11 00:10:03 +00:00
parent 8111539117
commit b2cc1487d1
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/app/WinBorder.cpp
+16 -13
View File
@@ -178,7 +178,18 @@ WinBorder::MoveBy(float x, float y)
return; return;
// lock here because we play with some regions // lock here because we play with some regions
if (GetRootLayer() && GetRootLayer()->Lock()) { if (GetRootLayer()) {
// TODO: MoveBy and ResizeBy() are usually called
// from the rootlayer's thread. HandleDirectConnection() could
// block the calling thread for ~3 seconds in the worst case,
// and while it would be acceptable if called from the
// ServerWindow's thread (only the window would be blocked), in this case
// it's not, as also the mouse movement is driven by rootlayer.
// Find some way to call DirectConnected() from the ServerWindow's thread,
// by sending a message from here or whatever.
Window()->HandleDirectConnection(B_DIRECT_STOP);
if (GetRootLayer()->Lock()) {
fDecRegion.OffsetBy(x, y); fDecRegion.OffsetBy(x, y);
fCumulativeRegion.OffsetBy(x, y); fCumulativeRegion.OffsetBy(x, y);
@@ -190,6 +201,10 @@ WinBorder::MoveBy(float x, float y)
Layer::MoveBy(x, y); Layer::MoveBy(x, y);
GetRootLayer()->Unlock(); GetRootLayer()->Unlock();
}
Window()->HandleDirectConnection(B_DIRECT_START|B_BUFFER_MOVED);
} else { } else {
// just offset to the new position // just offset to the new position
if (fDecorator) if (fDecorator)
@@ -203,18 +218,6 @@ WinBorder::MoveBy(float x, float y)
msg.AddInt64("when", system_time()); msg.AddInt64("when", system_time());
msg.AddPoint("where", Frame().LeftTop()); msg.AddPoint("where", Frame().LeftTop());
Window()->SendMessageToClient(&msg, B_NULL_TOKEN, false); Window()->SendMessageToClient(&msg, B_NULL_TOKEN, false);
// TODO: MoveBy and ResizeBy() are usually called
// from the rootlayer's thread. HandleDirectConnection() could
// block the calling thread for ~3 seconds in the worst case,
// and while it would be acceptable if called from the
// ServerWindow's thread (only the window would be blocked), in this case
// it's not, as also the mouse movement is driven by rootlayer.
// Find some way to call DirectConnected() from the ServerWindow's thread,
// by sending a message from here or whatever.
//Window()->HandleDirectConnection(B_DIRECT_STOP);
// Layer::MoveBy(x, y);
//Window()->HandleDirectConnection(B_DIRECT_START|B_BUFFER_MOVED);
} }