i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow only root access to the shadow password DB.

Browse Source 
git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@25005 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Ingo Weinhold
2008-04-17 17:58:51 +00:00
parent 2d9a40222f
commit b5a945d648
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/servers/registrar/AuthenticationManager.cpp
+11 -4
View File
@@ -542,7 +542,8 @@ AuthenticationManager::_RequestThread()
// request loop // request loop
while (true) { while (true) {
KMessage message; KMessage message;
status_t error = message.ReceiveFrom(fRequestPort); port_message_info messageInfo;
status_t error = message.ReceiveFrom(fRequestPort, -1, &messageInfo);
if (error != B_OK) if (error != B_OK)
return B_OK; return B_OK;
@@ -612,10 +613,13 @@ AuthenticationManager::_RequestThread()
case B_REG_GET_SHADOW_PASSWD_DB: case B_REG_GET_SHADOW_PASSWD_DB:
{ {
// TODO: Check permissions! // only root may see the shadow passwd
if (messageInfo.sender != 0)
error = EPERM;
// lazily build the reply // lazily build the reply
try { try {
if (fShadowPwdDBReply->What() == 1) { if (error == B_OK && fShadowPwdDBReply->What() == 1) {
FlatStore store; FlatStore store;
int32 count = fUserDB->WriteFlatShadowDB(store); int32 count = fUserDB->WriteFlatShadowDB(store);
if (fShadowPwdDBReply->AddInt32("count", count) != B_OK if (fShadowPwdDBReply->AddInt32("count", count) != B_OK
@@ -661,9 +665,12 @@ AuthenticationManager::_RequestThread()
if (error == B_OK && user == NULL) if (error == B_OK && user == NULL)
error = ENOENT; error = ENOENT;
// TODO: Check permissions!
bool getShadowPwd = message.GetBool("shadow", false); bool getShadowPwd = message.GetBool("shadow", false);
// only root may see the shadow passwd
if (error == B_OK && getShadowPwd && messageInfo.sender != 0)
error = EPERM;
// add user to message // add user to message
KMessage reply; KMessage reply;
if (error == B_OK) if (error == B_OK)