From b928a72b883d1bfac0979a3d4af0900bbc6100d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20A=C3=9Fmus?= Date: Thu, 8 Aug 2013 09:18:30 +0200 Subject: [PATCH] HaikuDepot: Layout and labeling tweaks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Swap rating and version in title view so it matches the order in the Ratings tab (rating XX for version YY). * Give a chance to decorate the version in translations. * Drop the pĆarenthesis around version in Ratings tab. --- src/apps/haiku-depot/PackageInfoView.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/apps/haiku-depot/PackageInfoView.cpp b/src/apps/haiku-depot/PackageInfoView.cpp index 0f2bc7f68d..d91589e1d5 100644 --- a/src/apps/haiku-depot/PackageInfoView.cpp +++ b/src/apps/haiku-depot/PackageInfoView.cpp @@ -394,13 +394,13 @@ public: .Add(fPublisherView) .End() .AddGlue(0.1f) - .Add(fVersionInfo) - .AddGlue(0.2f) .AddGroup(B_HORIZONTAL, B_USE_SMALL_SPACING) .Add(fRatingView) .Add(fAvgRating) .Add(fVoteInfo) .End() + .AddGlue(0.2f) + .Add(fVersionInfo) .AddGlue(3.0f) ; @@ -424,7 +424,9 @@ public: publisher.ReplaceAll("%Publisher%", package.Publisher().Name()); fPublisherView->SetText(publisher); - fVersionInfo->SetText(package.Version()); + BString version = B_TRANSLATE("%Version%"); + version.ReplaceAll("%Version%", package.Version()); + fVersionInfo->SetText(version); RatingSummary ratingSummary = package.CalculateRatingSummary(); @@ -722,7 +724,7 @@ public: ratingLabel.SetToFormat("%.1f", rating.Rating()); fRatingLabelView = new BStringView("rating label", ratingLabel); - BString versionLabel(B_TRANSLATE("(for %Version%)")); + BString versionLabel(B_TRANSLATE("for %Version%")); versionLabel.ReplaceAll("%Version%", rating.PackageVersion()); fPackageVersionView = new BStringView("package version", versionLabel);