From b9e10b079625d5ed7873cf1d17e65db013ceae6e Mon Sep 17 00:00:00 2001 From: Murai Takashi Date: Sat, 28 Nov 2020 07:58:55 +0900 Subject: [PATCH] Expander: Fix dead nested assignment Fix value stored to 'status' is never read. Pointed out by Clang Static Analyzer. Change-Id: I0bbeafb74168d566128b53f8ad40e71218c78c45 Reviewed-on: https://review.haiku-os.org/c/haiku/+/3473 Reviewed-by: Adrien Destugues --- src/apps/expander/ExpanderThread.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/apps/expander/ExpanderThread.cpp b/src/apps/expander/ExpanderThread.cpp index 15721be2fd..c93b826ef3 100644 --- a/src/apps/expander/ExpanderThread.cpp +++ b/src/apps/expander/ExpanderThread.cpp @@ -54,7 +54,7 @@ ExpanderThread::ThreadStartup() if ((status = GetDataStore()->FindRef("srcRef", &srcRef)) != B_OK) return status; - if ((status = GetDataStore()->FindRef("destRef", &destRef)) == B_OK) { + if (GetDataStore()->FindRef("destRef", &destRef) == B_OK) { BPath path(&destRef); chdir(path.Path()); } @@ -213,7 +213,7 @@ ExpanderThread::PipeCommand(int argc, const char** argv, int& in, int& out, int old_err = dup(2); int filedes[2]; - + // create new pipe FDs as stdout, stderr pipe(filedes); dup2(filedes[1], 1); close(filedes[1]); out = filedes[0]; // Read from out, taken from cmd's stdout @@ -250,7 +250,7 @@ ExpanderThread::PipeCommand(int argc, const char** argv, int& in, int& out, if (ioctl(slave, TIOCSCTTY, NULL) != 0) return -1; - dup2(slave, 0); + dup2(slave, 0); close(slave); // "load" command.