Fixed submenus for good

git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13151 a95241bf-73f2-0310-859d-f6bbb57e9c96

src/kits/interface/Menu.cpp

@@ -1116,24 +1116,22 @@ BMenu::_track(int *action, long start)
 			if (item != NULL) {
 				if (item != fSelected)
 					SelectItem(item);
+			}	
+			
+			int submenuAction = MENU_ACT_NONE;
+			BMenuItem *submenuItem = NULL;	
+			if (fSelected != NULL && fSelected->Submenu() != NULL) {
+				UnlockLooper();
 				
-				int submenuAction = MENU_ACT_NONE;
+				submenuItem = fSelected->Submenu()->_track(&submenuAction);
-				BMenuItem *submenuItem = NULL;	
+				if (submenuAction == MENU_ACT_CLOSE) {
-				// TODO: Review this as it doesn't work very well,
+					item = submenuItem;
-				// BMenu::_track() isn't always called when needed.
+					localAction = submenuAction;
-				if (item->Submenu() != NULL) {
+					break;
-					UnlockLooper();
-					
-					submenuItem = item->Submenu()->_track(&submenuAction);
-					if (submenuAction == MENU_ACT_CLOSE) {
-						item = submenuItem;
-						localAction = submenuAction;
-						break;
-					}
-					
-					if (!LockLooper())
-						break;
 				}
+				
+				if (!LockLooper())
+					break;
 			}
 																	
 			UnlockLooper();