From ba69a3795be79b65636d9bd8a62742d3eaef765a Mon Sep 17 00:00:00 2001 From: Stefano Ceccherini Date: Thu, 23 Jun 2005 13:22:58 +0000 Subject: [PATCH] Fixed a possible buffer overflow (thanks Axel). Removed a todo item git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@13236 a95241bf-73f2-0310-859d-f6bbb57e9c96 --- src/kits/interface/MenuItem.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/kits/interface/MenuItem.cpp b/src/kits/interface/MenuItem.cpp index ac0f3f5944..ed6c37a030 100644 --- a/src/kits/interface/MenuItem.cpp +++ b/src/kits/interface/MenuItem.cpp @@ -366,9 +366,7 @@ BMenuItem::DrawContent() if (fBounds.Width() > labelWidth) fSuper->DrawString(fLabel); else { - // TODO: Ouch! Allocating the string every time - // isn't exactly cheap. - char *truncatedLabel = new char[strlen(fLabel) + 1]; + char *truncatedLabel = new char[strlen(fLabel) + 4]; TruncateLabel(fBounds.Width(), truncatedLabel); fSuper->DrawString(truncatedLabel); delete[] truncatedLabel;