i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

btrfs: Add more validation checks in IsValid()

Browse Source 
Check that sector_size and node_size are powers of 2,
that node_size >= sector_size, total_size is non-zero,
and num_devices is non-zero.

Addresses the TODO comment in IsValid().

Change-Id: Id2c084f6b649a0315de1454a072ab1dcf3d0a3dd
Reviewed-on: https://review.haiku-os.org/c/haiku/+/10448
Haiku-Format: Haiku-format Bot <[email protected]>
Reviewed-by: Adrien Destugues <[email protected]>
This commit is contained in:
anujbillore-0-0
2026-03-10 12:24:51 +00:00
committed by Adrien Destugues
parent d754d09549
commit ba83d20148
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/add-ons/kernel/file_systems/btrfs/Volume.cpp
+12 -1
View File
@@ -49,10 +49,21 @@ btrfs_super_block::IsMagicValid() const
bool bool
btrfs_super_block::IsValid() const btrfs_super_block::IsValid() const
{ {
// TODO: check some more values!
if (!IsMagicValid()) if (!IsMagicValid())
return false; return false;
if (SectorSize() < 512 || (SectorSize() & (SectorSize() - 1)) != 0)
return false;
if (BlockSize() < SectorSize() || (BlockSize() & (BlockSize() - 1)) != 0)
return false;
if (TotalSize() == 0)
return false;
if (B_LENDIAN_TO_HOST_INT64(num_devices) == 0)
return false;
return true; return true;
} }