i2p/haiku-beta6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

* If bitmaps are drawn with alpha channel, it helps to setup the correct

Browse Source 
alpha mode. Thanks to Ralf Schuelke for pointing this out.
* Also check the bitmap color space and only use alpha drawing for bitmaps
  with valid alpha channel.
* Don't just reset the parent to B_OP_OVER, but use the previous mode.


git-svn-id: file:///srv/svn/repos/haiku/haiku/trunk@24031 a95241bf-73f2-0310-859d-f6bbb57e9c96
This commit is contained in:
Stephan Aßmus
2008-02-20 09:56:26 +00:00
parent 8ad2eabab3
commit bbf31e4d1f
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/kits/interface/ColumnTypes.cpp
+13 -2
View File
@@ -596,9 +596,20 @@ BBitmapColumn::DrawField(BField* field, BRect rect, BView* parent)
x = rect.right - kTEXT_MARGIN - r.Width(); x = rect.right - kTEXT_MARGIN - r.Width();
break; break;
} }
parent->SetDrawingMode(B_OP_ALPHA); // setup drawing mode according to bitmap color space,
// restore previous mode after drawing
drawing_mode oldMode = parent->DrawingMode();
if (bitmap->ColorSpace() == B_RGBA32
|| bitmap->ColorSpace() == B_RGBA32_BIG) {
parent->SetDrawingMode(B_OP_ALPHA);
parent->SetBlendingMode(B_PIXEL_ALPHA, B_ALPHA_OVERLAY);
} else {
parent->SetDrawingMode(B_OP_OVER);
}
parent->DrawBitmap(bitmap, BPoint(x, y)); parent->DrawBitmap(bitmap, BPoint(x, y));
parent->SetDrawingMode(B_OP_OVER);
parent->SetDrawingMode(oldMode);
} }
} }